AAP-19344: add data types for errors in catch block (#786)

* AAP-19344: add data types for errors in catch block
ansible · Jan 18, 2024 · c798c22 · c798c22 · github-actions · Jan 18, 2024
1 parent c682fd0
commit c798c22
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 10 deletions.
diff --git a/ansible_wisdom_console_react/src/ModelSettingsKey.tsx b/ansible_wisdom_console_react/src/ModelSettingsKey.tsx
@@ -1,6 +1,7 @@
+import { AxiosError } from "axios";
 import React, { useCallback, useMemo, useState } from "react";
 import "./ModelSettings.css";
-import { WcaKey, WcaKeyRequest } from "./api/types";
+import { APIException, WcaKey, WcaKeyRequest } from "./api/types";
 import { saveWcaKey } from "./api/api";
 import { HasError, NO_ERROR } from "./ErrorModal";
 import { DELAY } from "./api/globals";
@@ -29,14 +30,14 @@ export const ModelSettingsKey = (props: ModelSettingsKeyProps) => {
         .then((_) => {
           reload();
         })
-        .catch((error) => {
+        .catch((error: AxiosError<APIException, any>) => {
           if (error.response?.status === 400) {
             setIsKeyInvalid(true);
           } else {
             setKeyError({
               inError: true,
               message: error.message,
-              detail: error.response?.data?.detail,
+              detail: error.response?.data?.detail ?? "",
             });
           }
         })

diff --git a/ansible_wisdom_console_react/src/ModelSettingsModelId.tsx b/ansible_wisdom_console_react/src/ModelSettingsModelId.tsx
@@ -1,6 +1,7 @@
+import { AxiosError } from "axios";
 import React, { useCallback, useMemo, useState } from "react";
 import "./ModelSettings.css";
-import { WcaModelId, WcaModelIdRequest } from "./api/types";
+import { APIException, WcaModelId, WcaModelIdRequest } from "./api/types";
 import { saveWcaModelId } from "./api/api";
 import { HasError, NO_ERROR } from "./ErrorModal";
 import { DELAY } from "./api/globals";
@@ -32,14 +33,14 @@ export const ModelSettingsModelId = (props: ModelSettingsModelIdProps) => {
         .then((_) => {
           reload();
         })
-        .catch((error) => {
+        .catch((error: AxiosError<APIException, any>) => {
           if (error.response?.status === 400) {
             setIsModelIdInvalid(true);
           } else {
             setModelIdError({
               inError: true,
               message: error.message,
-              detail: error.response?.data?.detail,
+              detail: error.response?.data?.detail ?? "",
             });
           }
         })

diff --git a/ansible_wisdom_console_react/src/ModelSettingsOverview.tsx b/ansible_wisdom_console_react/src/ModelSettingsOverview.tsx
@@ -93,14 +93,14 @@ export const ModelSettingsOverview = (props: ModelSettingsOverviewProps) => {
       .then((_) => {
         alertsRef.current?.addAlert(t("KeyValidationSuccess"));
       })
-      .catch((error) => {
+      .catch((error: AxiosError<APIException, any>) => {
         if (error.response?.status === 400) {
           setIsKeyInvalid(true);
         } else {
           setKeyError({
             inError: true,
             message: error.message,
-            detail: error.response?.data?.detail,
+            detail: error.response?.data?.detail ?? "",
           });
         }
       })

diff --git a/ansible_wisdom_console_react/src/TelemetrySettings.tsx b/ansible_wisdom_console_react/src/TelemetrySettings.tsx
@@ -1,3 +1,4 @@
+import { AxiosError } from "axios";
 import React, {
   useCallback,
   useEffect,
@@ -25,6 +26,7 @@ import {
 } from "@patternfly/react-core";
 import "./ModelSettings.css";
 import {
+  APIException,
   Success,
   Telemetry,
   TelemetryRequest,
@@ -94,11 +96,11 @@ export function TelemetrySettings() {
           alertsRef.current?.addAlert(t("TelemetryOptInSaveSuccessAlert"));
         }
       })
-      .catch((error) => {
+      .catch((error: AxiosError<APIException, any>) => {
         setTelemetrySettingsError({
           inError: true,
           message: error.message,
-          detail: error.response?.data?.detail,
+          detail: error.response?.data?.detail ?? "",
         });
       })
       .finally(() => {