[REFACTORING DRAFT]Telemetry #1105
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
goneri
force-pushed
the
goneri/Telemetry-Schema-2-for-Playbook-Exp-Gen_31
branch
from
55a1332
to
7896615
Compare
Push events when: - we preare an explanation for a playbook - or we generate a new one Also: - rename `PlaybookOutlineFeedback` as `PlaybookGenerationFeedback` and accept the `wizardId` parameter. - rename `ContentMatches._write_to_segment()` to `ContentMatches.write_to_segment()` to match the other class of the module.
goneri
force-pushed
the
goneri/Telemetry-Schema-2-for-Playbook-Exp-Gen_31
branch
from
7896615
to
e5a74e6
Compare
goneri
changed the title
goneri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push events when:
Also:
PlaybookOutlineFeedbackasPlaybookGenerationFeedbackandaccept the
wizardIdparameter.ContentMatches._write_to_segment()toContentMatches.write_to_segment()to match the other class of the module.