Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR to update node version to 21.x from 20.x #1361

Closed
wants to merge 2 commits into from

Conversation

justjais
Copy link
Contributor

Jira Issue: related to https://issues.redhat.com/browse/AAP-31381

Description

PR to update node version to 21.x from existing 20.x. This is to fix the CVE around serialize-javascript, please ref the #1353 (comment)

Testing

Steps to test

  1. Pull down the PR
  2. Install node 21.x in your machine
  3. Run npm install, and the CI failure observed here should not be observable with the upgraded node.

Scenarios tested

NA

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

@justjais justjais mentioned this pull request Oct 23, 2024
2 tasks
@justjais justjais requested a review from mabulgu October 23, 2024 11:56
Copy link
Contributor

@mabulgu mabulgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jameswnl jameswnl closed this Oct 23, 2024
@jameswnl jameswnl reopened this Oct 23, 2024
@justjais
Copy link
Contributor Author

closing this PR in favor of #1362, as this PR has some weird CI failure

@justjais justjais closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants