PR to upgrade node from 20.x to 21.x #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@jameswnl I created this PR as new, and has single verified commit. Plz approve and merge it, as the synk CI test failure is unrelated to the changes and also seems limitation going by the error reported. |
2 tasks
jameswnl
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue: related to https://issues.redhat.com/browse/AAP-31381
Description
PR to update node version to 21.x from existing 20.x. This is to fix the CVE around serialize-javascript, please ref the #1353 (comment)
Testing
Steps to test
npm install, and the CI failure observed here should not be observable with the upgraded node.Scenarios tested
NA
Production deployment