Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix main branch pre-commit issues #1433

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Fix main branch pre-commit issues #1433

merged 1 commit into from
Nov 28, 2024

Conversation

hasys
Copy link
Contributor

@hasys hasys commented Nov 28, 2024

Jira Issue: No Kira issues.

Description

New PRs rebased to main are failing with unrelated pre-commit issues. Fixing those issues in separate PR to not pollute the history.

Testing

Steps to test

  1. All checks are green

Scenarios tested

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

Copy link
Contributor

@mabulgu mabulgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. but how come we did not apply these commits? so some people on the team might not have those precommit hooks set up properly? possibly the new folks?

@hasys hasys merged commit d36f7f5 into main Nov 28, 2024
10 checks passed
@hasys hasys deleted the precommit branch November 28, 2024 12:01
@hasys
Copy link
Contributor Author

hasys commented Nov 28, 2024

lgtm. but how come we did not apply these commits? so some people on the team might not have those precommit hooks set up properly? possibly the new folks?

@mabulgu good question. Not sure, pre-commit started fail to me after I rebased #1432 to main branch, but all previously merged PRs are green. Not sure what happened. Maybe, we have configured pre-commit to use latest version, it updated and our checks started to fail. Only possible reason popping in my mind right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants