Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAP-36512: FIx Admin portal tests fallout due to PF5 and latest Ansible-UI-framework #1475

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

manstis
Copy link
Contributor

@manstis manstis commented Jan 2, 2025

Jira Issue: https://issues.redhat.com/browse/AAP-36512

Description

Reinstate a test that was removed as part of the miration to PF5.

Testing

N/A. This PR contains a reinstated unit test.

Steps to test

N/A. This PR contains a reinstated unit test.

Scenarios tested

N/A. This PR contains a reinstated unit test.

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

@manstis manstis requested a review from justjais January 2, 2025 11:01
Copy link

github-actions bot commented Jan 2, 2025

# npm audit report

nanoid  <3.3.8
Severity: moderate
Predictable results in nanoid generation when given non-integer values - https://github.com/advisories/GHSA-mwcw-c2x4-8c55
fix available via `npm audit fix`
node_modules/nanoid

path-to-regexp  <0.1.12
Severity: moderate
Unpatched `path-to-regexp` ReDoS in 0.1.x - https://github.com/advisories/GHSA-rhx6-c78j-4q9w
fix available via `npm audit fix`
node_modules/path-to-regexp
  express  4.0.0-rc1 - 4.21.1 || 5.0.0-alpha.1 - 5.0.0-beta.3
  Depends on vulnerable versions of path-to-regexp
  node_modules/express

3 moderate severity vulnerabilities

To address all issues, run:
  npm audit fix

@manstis manstis requested a review from hasys January 2, 2025 11:06
Copy link

sonarqubecloud bot commented Jan 2, 2025

Copy link
Contributor

@hasys hasys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you @manstis !

@manstis manstis merged commit 229f711 into main Jan 2, 2025
12 checks passed
@manstis manstis deleted the AAP-36512 branch January 2, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants