Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scaffolding for role explanation endpoint #1526

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

mabashian
Copy link
Member

Jira Issue: https://issues.redhat.com/browse/AAP-39792

Description

An attempt to scaffold in the role explanation endpoint

Testing

Steps to test

  1. Pull down the PR
  2. Check out the swagger api schema and compare against proposal in Jira
  3. Ensure unit tests run successfully

Scenarios tested

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

manstis
manstis previously approved these changes Feb 11, 2025
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 (A small comment, but harmless nonetheless).

You're the first developer to make new changes using:

  • Versioned API
  • AACSAPIView base class

You're also one of the first to make new changes using:

  • ai/api/model_pipelines

What was your experience?

@mabashian mabashian marked this pull request as ready for review February 12, 2025 16:24
@mabashian
Copy link
Member Author

@manstis most (really almost all) of this work was simply following the patterns already established but I didn't find it too cumbersome to work with this architecture. If I'm honest I'm still a bit confused on whether this endpoint should be added to v0. It's currently included in the v0 urls but should it only be available in v1?

@mabashian mabashian requested a review from manstis February 12, 2025 19:49
@mabashian mabashian merged commit 62ac733 into main Feb 13, 2025
11 checks passed
@mabashian mabashian deleted the mabashian/AAP-39792 branch February 13, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants