Skip to content

Ignore __screenshots__ folders generated during test execution.#1603

Merged
manstis merged 2 commits intomainfrom
ignore_screenshots
Apr 4, 2025
Merged

Ignore __screenshots__ folders generated during test execution.#1603
manstis merged 2 commits intomainfrom
ignore_screenshots

Conversation

@manstis
Copy link
Contributor

@manstis manstis commented Apr 4, 2025

This PR does not need a corresponding Jira item.

Description

Add __screenshots__ folders to .gitignore and tidy-up existing resources.

Testing

N/A

Steps to test

N/A

Scenarios tested

N/A

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

@manstis manstis requested a review from TamiTakamiya April 4, 2025 13:10
@github-actions
Copy link

github-actions bot commented Apr 4, 2025

# npm audit report

prismjs  <1.30.0
Severity: moderate
PrismJS DOM Clobbering vulnerability - https://github.com/advisories/GHSA-x7hr-w5r2-h6wg
No fix available
node_modules/refractor/node_modules/prismjs
  refractor  <=4.6.0
  Depends on vulnerable versions of prismjs
  node_modules/refractor
    react-syntax-highlighter  >=6.0.0
    Depends on vulnerable versions of refractor
    node_modules/react-syntax-highlighter
      @patternfly/chatbot  *
      Depends on vulnerable versions of react-syntax-highlighter
      node_modules/@patternfly/chatbot

vite  6.2.0 - 6.2.3
Severity: moderate
Vite has a `server.fs.deny` bypassed for `inline` and `raw` with `?import` query - https://github.com/advisories/GHSA-4r4m-qw57-chr8
fix available via `npm audit fix`
node_modules/vite

5 moderate severity vulnerabilities

To address issues that do not require attention, run:
  npm audit fix

Some issues need review, and may require choosing
a different dependency.

@github-actions
Copy link

github-actions bot commented Apr 4, 2025

# npm audit report

prismjs  <1.30.0
Severity: moderate
PrismJS DOM Clobbering vulnerability - https://github.com/advisories/GHSA-x7hr-w5r2-h6wg
No fix available
node_modules/refractor/node_modules/prismjs
  refractor  <=4.6.0
  Depends on vulnerable versions of prismjs
  node_modules/refractor
    react-syntax-highlighter  >=6.0.0
    Depends on vulnerable versions of refractor
    node_modules/react-syntax-highlighter
      @patternfly/chatbot  *
      Depends on vulnerable versions of react-syntax-highlighter
      node_modules/@patternfly/chatbot

4 moderate severity vulnerabilities

Some issues need review, and may require choosing
a different dependency.

@manstis
Copy link
Contributor Author

manstis commented Apr 4, 2025

There's no fix available for the npm audit issue:

#1603 (comment)

Copy link
Contributor

@TamiTakamiya TamiTakamiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manstis Thank you very much, it should have been done long before....

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 4, 2025

@manstis manstis merged commit 3538386 into main Apr 4, 2025
10 of 11 checks passed
@manstis manstis deleted the ignore_screenshots branch April 4, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants