Skip to content

AAP Chatbot: GH workflows fixes.#1605

Merged
romartin merged 1 commit intomainfrom
aap-chatbot-gha-fix
Apr 7, 2025
Merged

AAP Chatbot: GH workflows fixes.#1605
romartin merged 1 commit intomainfrom
aap-chatbot-gha-fix

Conversation

@romartin
Copy link
Contributor

@romartin romartin commented Apr 7, 2025

Some fixes for the AAP Chatbot GH actions, also now it is creating a PR, instead of commiting, so hopefully will work on the upstream.

Tested latest changes in my own fork: https://github.com/romartin/ansible-ai-connect-service/actions

Thanks!

Copy link
Contributor

@TamiTakamiya TamiTakamiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

TamiTakamiya
TamiTakamiya previously approved these changes Apr 7, 2025
@romartin
Copy link
Contributor Author

romartin commented Apr 7, 2025

@TamiTakamiya @jameswnl Now it creates a PR. Please need for a new Secret in this repo, see description on top.

Thanks!

TamiTakamiya
TamiTakamiya previously approved these changes Apr 7, 2025
Copy link
Contributor

@TamiTakamiya TamiTakamiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!!

@romartin
Copy link
Contributor Author

romartin commented Apr 7, 2025

Not merging until @jameswnl or @manstis confirm they have set the Secrets as described in this PR.

Thanks!

Signed-off-by: romartin <roger600@gmail.com>
@romartin
Copy link
Contributor Author

romartin commented Apr 7, 2025

sorry. no need for the Secret, merging.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2025

@romartin romartin merged commit 48cc598 into main Apr 7, 2025
8 checks passed
@romartin romartin deleted the aap-chatbot-gha-fix branch April 7, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants