Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAP-19486: Set minimal requirements for Admin Portal #781

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

hasys
Copy link
Contributor

@hasys hasys commented Jan 12, 2024

Jira Issue: https://issues.redhat.com/browse/AAP-19486

Description

Minimal node and npm are set based on the used libraries and it's minimal requirements.

For the node [email protected] library has minimal requirement node 18.0.0
For the npm several libraries (for example csso and css-tree) requires minimal npm 7.0.0

Testing

Steps to test

  1. Pull down the PR
  2. Check package.json
  3. Check README.md

Scenarios tested

Production deployment

  • This code change is ready for production on its own

@hasys hasys requested a review from manstis January 12, 2024 13:24
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks.

@hasys hasys merged commit aba9dd1 into main Jan 12, 2024
5 checks passed
@hasys hasys deleted the minimal_req branch January 12, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants