Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAP-19491: Enable pretifier for js and ts code on pre-commit #782

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

hasys
Copy link
Contributor

@hasys hasys commented Jan 12, 2024

Jira Issue: https://issues.redhat.com/browse/AAP-19491

Description

The javascript and typescript code should be pretified automatically on pre-commit action as it is done for the python code

Testing

Steps to test

  1. Pull down the PR
  2. Do change in *.js, *.ts or *.tsx files to break the prettier rules and try to commit.
  3. You should see that your change is corrected or reverted
  4. Example of the change can be using incorrect formatting or using ' instead of " for string literals
  5. Another test can be change files with different extensions (not js ts or tsx) and see that prettier pre-commit phase is skipped.

Scenarios tested

Described above.

Production deployment

  • This code change is ready for production on its own

@hasys hasys requested a review from manstis January 12, 2024 15:39
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank-you. LGTM 👍

@hasys hasys merged commit e5cee4c into main Jan 12, 2024
5 checks passed
@hasys hasys deleted the auto-prettier branch January 12, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants