Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAP-20935: Console: Use correct Admin Dashboard URL #839

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

manstis
Copy link
Contributor

@manstis manstis commented Feb 20, 2024

Jira Issue: https://issues.redhat.com/browse/AAP-20935

Description

Fix the URL shown in the "Console" for the "Admin Dashboard".

Testing

Login to Lightspeed with an Org Admin for which "Schema 2 telemetry" is enabled. Navigate to the "Console".

The URL for the "admin dashboard" should be for consoledot/HCC.

Steps to test

  1. Pull down the PR
  2. make start-backends
  3. make create-application
  4. npm --prefix ./ansible_wisdom_console_react install
  5. make admin-portal-bundle
  6. Start wisdom-service in whatever way you normally do.
  7. Login with an Org Admin user for which "Schema 2 telemetry" is enabled.
  8. Navigate to the "Console"
  9. Navigate to the "Telemetry" section
  10. Check the "admin dashboard" URL.

Scenarios tested

As above.

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

@manstis manstis added the pr-deployment To trigger a deployment based on this PR's image label Feb 20, 2024
@manstis
Copy link
Contributor Author

manstis commented Feb 20, 2024

Hi @jameswnl I was trying the pr-deployment label 🥳

However when trying to login to the newly created deployment I see this:

image

What should I do?

@manstis
Copy link
Contributor Author

manstis commented Feb 20, 2024

@goneri @jameswnl @robinbobbitt any one of your reviews is welcome 😃

@manstis
Copy link
Contributor Author

manstis commented Feb 20, 2024

Sonar Cloud complains about code coverage on the following:

It is not possible to write unit tests for these.

@jameswnl
Copy link
Contributor

Hi @jameswnl I was trying the pr-deployment label 🥳

However when trying to login to the newly created deployment I see this:

image

What should I do?

That's expected for now, RH SSO won't work.
we may consider to enable the local Django auth for pr-deployment

@manstis manstis removed the pr-deployment To trigger a deployment based on this PR's image label Feb 20, 2024
@jameswnl jameswnl added the pr-deployment To trigger a deployment based on this PR's image label Feb 26, 2024
@goneri
Copy link
Contributor

goneri commented Feb 26, 2024

Works as expected for me, tested locally.

@manstis manstis merged commit df63b72 into main Feb 26, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-deployment To trigger a deployment based on this PR's image
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants