Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Dashboard: [Feature flag] Drop -M-A-G-I-C- Organizations #893

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

romartin
Copy link
Contributor

@romartin romartin commented Mar 22, 2024

Jira Issue: https://issues.redhat.com/browse/AAP-21992

Description

Drop the use of the is_schema_2_enabled flag, from both wisdom-service, admin dashboard, and finally in LaunchDarkly.
PS: This PR basically reverts some work from #814

Testing

Steps to test

  1. Pull down the PR
  2. Start the wisdom-service locally
  3. Login by using a licensed user
  4. Perform inference or sentiment feedback
  5. Look at Segment and see events flowing for schema2, in case your org is opted-in
  6. Also run the Admin Portal (ansible_wisdom_console_react) and check you can also see and access the Telemetry settings page
  7. Tested also opting-in/out

Scenarios tested

Locally, as described above

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

Remove the (no longer used) flag schema_2_telemetry_org_enabled in Launch Darkly, for all Dev, Stage and Prod environments.

@romartin romartin requested a review from manstis March 22, 2024 00:37
Copy link

# npm audit report

webpack-dev-middleware  <=5.3.3
Severity: high
Path traversal in webpack-dev-middleware - https://github.com/advisories/GHSA-wr3j-pwj9-hqq6
fix available via `npm audit fix`
node_modules/webpack-dev-middleware

1 high severity vulnerability

To address all issues, run:
  npm audit fix

@romartin romartin requested a review from robinbobbitt March 22, 2024 01:46
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you deleted two tests by accident.

They relate to @hasys work and not telemetry.

@romartin
Copy link
Contributor Author

romartin commented Mar 25, 2024

@manstis @robinbobbitt I guess all tests are fixed now.

It was just missing to drop some tests that were related to is_schema2_telemetry_enabled logic, which now does no longer exists.

Thanks!

manstis
manstis previously approved these changes Mar 25, 2024
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@romartin
Copy link
Contributor Author

@manstis can you please approve again? comment removed

Copy link

# npm audit report

express  <4.19.2
Severity: moderate
Express.js Open Redirect in malformed URLs - https://github.com/advisories/GHSA-rv95-896h-c2vc
fix available via `npm audit fix`
node_modules/express

1 moderate severity vulnerability

To address all issues, run:
  npm audit fix

manstis
manstis previously approved these changes Mar 26, 2024
@romartin
Copy link
Contributor Author

@manstis can you please approve again? npm audit fixed. Thanks!

@romartin romartin merged commit 05949b8 into main Mar 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants