-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin Dashboard: [Feature flag] Drop -M-A-G-I-C- Organizations #893
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you deleted two tests by accident.
They relate to @hasys work and not telemetry.
@manstis @robinbobbitt I guess all tests are fixed now. It was just missing to drop some tests that were related to Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@manstis can you please approve again? comment removed |
|
@manstis can you please approve again? npm audit fixed. Thanks! |
Jira Issue: https://issues.redhat.com/browse/AAP-21992
Description
Drop the use of the is_schema_2_enabled flag, from both wisdom-service, admin dashboard, and finally in LaunchDarkly.
PS: This PR basically reverts some work from #814
Testing
Steps to test
ansible_wisdom_console_react
) and check you can also see and access the Telemetry settings pageScenarios tested
Locally, as described above
Production deployment
Remove the (no longer used) flag schema_2_telemetry_org_enabled in Launch Darkly, for all Dev, Stage and Prod environments.