fix: invert ansible-core 2.20 python 3.14 logic#582
Open
eb4x wants to merge 1 commit intoansible:mainfrom
Open
fix: invert ansible-core 2.20 python 3.14 logic#582eb4x wants to merge 1 commit intoansible:mainfrom
eb4x wants to merge 1 commit intoansible:mainfrom
Conversation
eb4x
force-pushed
the
invert_blocker_logic
branch
from
3d83b30 to
95c0f1c
Compare
eb4x
changed the title
eb4x
force-pushed
the
invert_blocker_logic
branch
from
95c0f1c to
d2345b2
Compare
Python 3.14 cares about python code. ansible-core 2.20 might have introduced some python code that makes a hard requirement on 3.14, but it's certainly not the other way around.
eb4x
force-pushed
the
invert_blocker_logic
branch
from
d2345b2 to
b8f0c5a
Compare
Author
|
Hey @ssbarnea , can you please have a look at this. Trying to rectify an issue caused by #533. I'm not quite sure what do do here, mostly tempted to just remove it all, but you might better judge this. The main point is this logic is flawed. Python 3.14 doesn't depend on ansible-core, it doesn't care or even know about ansible-core. Some versions of ansible-core might have a minimum runtime requirement of python. But even the tests here seem to run py312 with ansible-devel. So maybe python 3.14 isn't even the correct minimum requirement anymore? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.14 cares about python code. ansible-core 2.20 might have introduced some python code that makes a hard requirement on 3.14, but it's certainly not the other way around.