Skip to content

Add rule to verify that galaxy.yml collection version is present and >= 1.0.0 #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 16, 2022

Conversation

KB-perByte
Copy link
Member

@KB-perByte KB-perByte commented Sep 2, 2022

Rule to check collection version in galaxy.yml is >= 1.0.0

---
name: foo
namespace: bar
version: 0.2.3 # <-- collection version should be <= 1.0.0
authors:
  - John
readme: ../README.md
description: "..."

Fixes: #2103

@KB-perByte KB-perByte requested a review from a team as a code owner September 2, 2022 09:24
@KB-perByte KB-perByte requested review from a team, ssbarnea, ganeshrn and shatakshiiii September 2, 2022 09:24
@ssbarnea
Copy link
Member

ssbarnea commented Sep 2, 2022

Do not bother to put the code in a shared lib yet, we can do it as soon we will need it.

@ssbarnea ssbarnea requested a review from cidrblock September 5, 2022 14:43
@ssbarnea
Copy link
Member

@KB-perByte Any reason for not using the version parsing from packaging module? We already list it as a dependency. See https://stackoverflow.com/questions/11887762/how-do-i-compare-version-numbers-in-python

@ssbarnea ssbarnea added incomplete Additional work or information is required enhancement labels Sep 12, 2022
@ssbarnea ssbarnea removed the incomplete Additional work or information is required label Sep 16, 2022
@ssbarnea ssbarnea changed the title Rule to check collection version in galaxy.yml is >= 1.0.0 Add rule to verify that galaxy.yml collection version is present and >= 1.0.0 Sep 16, 2022
@ssbarnea ssbarnea merged commit 9fd8947 into ansible:main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meta-version: confirm collection version is >= 1.0.0
2 participants