Skip to content

4578: utils.is_playbook support fqcn import_playbook #4580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OscarBell
Copy link

Updated utils.is_playbook function to support the fqcn version of import_playbook to detect a valid playbook file.

@OscarBell
Copy link
Author

This PR will solve issue: #4578

@OscarBell
Copy link
Author

Alternatively if the playbooks_keys needs to be unadjusted we could change below line
if not isinstance(item, Mapping) or not playbooks_keys.intersection( item.keys() ):
into
if not isinstance(item, Mapping) or not playbooks_keys.intersection( {item.split('.')[-1] for item in item.keys()} ):
With above solution all keys found in the play will be changed into the non-fqcn variant and can be compared against the playbook_keys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants