docs: fix rulebooks documentation for missing gather_facts #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I have this right, I'll follow up on the other one I had in my previous PR, along with some others I found that are related to it (FQCN). Thanks, |
|
jeffmcutter
force-pushed
the
fix_rulebooks_gather_facts
branch
from
1ffd405 to
5032a15
Compare
jeffmcutter
changed the title
|
I installed pre-commit. Does pre-commit not check that or did I go wrong with my pre-commit install? Thanks, |
mkanoor
approved these changes
Dec 12, 2023
Alex-Izquierdo
approved these changes
Dec 12, 2023
|
Thanks to point out this issue and for your efffort @jeffmcutter ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gather_facts defaults to false and needs to be set to true in order to interact with facts as this sample does.