Skip to content

Consolidate how we run linters #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ssbarnea wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Consolidate how we run linters #1106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,9 @@ repos:
rev: v2.0.0
hooks:
- id: flake8
- repo: https://github.com/adrienverge/yamllint
Copy link
Contributor

@eqrx eqrx Jul 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would agree with @Shrews and remove this file altogether since it is not used

rev: v1.27.1
hooks:
- id: yamllint
args:
- --strict
7 changes: 3 additions & 4 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,10 @@ commands = pytest {posargs}
[testenv:linters]
description = Run code linters
basepython = python3.8
deps =
pre-commit
commands=
flake8 --version
flake8 docs ansible_runner test
yamllint --version
yamllint -s .
pre-commit run -a

[testenv:unit{,-py38,-py39,-py310}]
description = Run unit tests
Expand Down