Skip to content

fix: make rotate_artifacts accessible from settings file#1479

Closed
dmzoneill wants to merge 1 commit intoansible:develfrom
Redhat-forks:fix/issue-1415-rotate-artifacts-settings
Closed

fix: make rotate_artifacts accessible from settings file#1479
dmzoneill wants to merge 1 commit intoansible:develfrom
Redhat-forks:fix/issue-1415-rotate-artifacts-settings

Conversation

@dmzoneill
Copy link
Member

fixes #1415

added rotate_artifacts to the settings loading section so it can be configured via the settings file, matching the pattern used by other config options like suppress_output_file and container_options.

now you can set rotate_artifacts in your settings file and it'll work as expected.

@dmzoneill dmzoneill requested a review from a team as a code owner February 10, 2026 19:59
Copy link
Contributor

@Shrews Shrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests.


self.suppress_output_file = self.settings.get('suppress_output_file', False)
self.suppress_ansible_output = self.settings.get('suppress_ansible_output', self.quiet)
self.rotate_artifacts = self.settings.get('rotate_artifacts', self.rotate_artifacts)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmzoneill dmzoneill closed this Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make rotate_artifacts accessible from env/settings

3 participants

Comments