Skip to content

Remove unused exports and deprecated code#3128

Open
h-kataria wants to merge 1 commit intodevelfrom
remove-dead-code
Open

Remove unused exports and deprecated code#3128
h-kataria wants to merge 1 commit intodevelfrom
remove-dead-code

Conversation

@h-kataria
Copy link
Copy Markdown
Contributor

@h-kataria h-kataria commented Apr 21, 2026

Remove high-confidence dead code identified through codebase analysis:

  • Remove useSelectUsersRemoveTeams hook (only usage is commented out)
  • Remove useRolesFilters hook (duplicate of useAwxRolesFilters)
  • Remove USER_GROUP_MGMT_PERMISSIONS constant (no imports found)
  • Remove ILicenseInfo interface (never imported)
  • Remove deprecated useMultiSelectCredential function (no external usage)

These items were verified to have no active imports or usage in the codebase.

Summary

Type of Change

  • Bug fix
  • Enhancement
  • Tests
  • Documentation
  • Other (please specify)

Risk Analysis - REQUIRED

  • High — Broad platform impact (e.g., SWR config, shared framework components, authentication, routing, API wrappers, build/bundler config). Changes affect multiple workspaces or could cause widespread regressions.
  • Medium — Scoped but cross-cutting (e.g., shared utility functions, changes to multiple pages within one workspace, component library updates, test infrastructure). Limited blast radius but touches common code paths.
  • Low — Narrowly scoped (e.g., single page fix, styling tweak, documentation, test-only changes, copy/string updates). Minimal risk of unintended side effects.

Dependencies

Testing

Ephemeral E2E Tests

Once PR is ready and preliminary checks pass, trigger tests by posting a comment /run-playwright on this PR.

Tests run against a fresh AAP instance (version based on branch).

External Server E2E Runs

Manual Testing

Screenshots

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk Analysis is required. Please select a risk level (High, Medium, or Low) in the PR description under Risk Analysis - REQUIRED.

@github-actions github-actions Bot dismissed their stale review April 21, 2026 20:07

Risk analysis provided.

@h-kataria h-kataria force-pushed the remove-dead-code branch 2 times, most recently from 074e717 to 55f0530 Compare April 21, 2026 21:06
  Remove high-confidence dead code identified through codebase analysis:

  - Remove useSelectUsersRemoveTeams hook (only usage is commented out)
  - Remove useRolesFilters hook (duplicate of useAwxRolesFilters)
  - Remove USER_GROUP_MGMT_PERMISSIONS constant (no imports found)
  - Remove ILicenseInfo interface (never imported)
  - Remove deprecated useMultiSelectCredential function (no external usage)

  These items were verified to have no active imports or usage in the codebase.
@sonarqubecloud
Copy link
Copy Markdown

@h-kataria
Copy link
Copy Markdown
Contributor Author

/run-playwright

@aap-pde-ci-bot
Copy link
Copy Markdown
Collaborator

Currents dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants