Skip to content

Update polling retries after timeout#3144

Open
daphnemaeve wants to merge 3 commits intodevelfrom
resolve-extra-polling-after-timeout
Open

Update polling retries after timeout#3144
daphnemaeve wants to merge 3 commits intodevelfrom
resolve-extra-polling-after-timeout

Conversation

@daphnemaeve
Copy link
Copy Markdown
Contributor

@daphnemaeve daphnemaeve commented Apr 28, 2026

Summary

Added a global onErrorRetry handler to the SWR configuration that:

  • Detects 401 Unauthorized responses (error?.statusCode === 401)
  • Returns false to stop retrying immediately
  • Preserves SWR's default retry logic for other errors
  • Maintains existing session management system

Type of Change

  • Bug fix
  • Enhancement
  • Tests
  • Documentation
  • Other (please specify)

Risk Analysis - REQUIRED

  • High — Broad platform impact (e.g., SWR config, shared framework components, authentication, routing, API wrappers, build/bundler config). Changes affect multiple workspaces or could cause widespread regressions.
  • Medium — Scoped but cross-cutting (e.g., shared utility functions, changes to multiple pages within one workspace, component library updates, test infrastructure). Limited blast radius but touches common code paths.
  • Low — Narrowly scoped (e.g., single page fix, styling tweak, documentation, test-only changes, copy/string updates). Minimal risk of unintended side effects.

Dependencies

Testing

Ephemeral E2E Tests

Once PR is ready and preliminary checks pass, trigger tests by posting a comment /run-playwright on this PR.

Tests run against a fresh AAP instance (version based on branch).

External Server E2E Runs

Manual Testing

Screenshots

@daphnemaeve
Copy link
Copy Markdown
Contributor Author

/run-playwright

@aap-pde-ci-bot
Copy link
Copy Markdown
Collaborator

Currents dashboard

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please select only one risk level (High, Medium, or Low).

@github-actions github-actions Bot dismissed their stale review April 28, 2026 16:37

Risk analysis provided.

@daphnemaeve
Copy link
Copy Markdown
Contributor Author

/run-playwright

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@aap-pde-ci-bot
Copy link
Copy Markdown
Collaborator

Currents dashboard

keithjgrant
keithjgrant previously approved these changes Apr 29, 2026
@sonarqubecloud
Copy link
Copy Markdown

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants