[AAP-55913] Backport pagination fix PR #84 to stable-2.6#111
Open
web3dozie wants to merge 1 commit intoansible:stable-2.6from
Open
[AAP-55913] Backport pagination fix PR #84 to stable-2.6#111web3dozie wants to merge 1 commit intoansible:stable-2.6from
web3dozie wants to merge 1 commit intoansible:stable-2.6from
Conversation
Cherry-pick of commit 60f4705 from devel branch. Fixes malformed request URLs when ansible.platform.gateway_api lookup plugin needs to fetch more than one page of results. The build_url function now strips the scheme and hostname from fully qualified URLs returned in pagination responses. Co-Authored-By: Ivan Aragonés Muniesa <26822043+ivarmu@users.noreply.github.com>
|
DVCS PR Check Results: PR appears valid (JIRA key(s) found) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
What is being changed?
build_urlfix from PR AAP-47990 - Bugfix: add a fix to let the pagination to work well #84 tostable-2.6Why is this change needed?
ansible.platform.gateway_apilookup plugin fetches paginated resultsbuild_urlfunction incorrectly prependsapi/gateway/v1/to fully-qualified URLs returned in pagination responsesHow does this change address the issue?
http://orhttps://before further processingapi/gateway/v1/https://hostname/api/...Type of Change
Self-Review Checklist
Testing Instructions
Prerequisites
Steps to Test
Expected Results
api/gateway/v1/https://...in error messagesTested Results
api/gateway/v1/https://<host>/api/galaxy/pulp/api/v3/roles/?limit=5&offset=5(404)Additional Context
Backport of:
Original PR merged to
develon Dec 11, 2025. This backport brings the fix to customers on the stable-2.6 release line.Required Actions
stable-2.5as well