Skip to content

Update Skip replicas field when set to 0 for autoscaler(eg. KEDA) compatibility #2078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
argon-kr wants to merge 2 commits into
base: devel
Choose a base branch
from
+8 −8
Open

Update Skip replicas field when set to 0 for autoscaler(eg. KEDA) compatibility #2078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e41ffe9
Update Skip replicas field when set to 0 for other scaler(eg. KEDA) c…
argon-kr Aug 31, 2025
003d9b2
Update molecule test for this PR
argon-kr Aug 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions molecule/default/tasks/awx_replicas_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@

- include_tasks: _test_case_replicas.yml
vars:
expected_web_replicas: 0
expected_task_replicas: 0
expected_web_replicas: 1
expected_task_replicas: 1

####

Expand Down Expand Up @@ -43,8 +43,8 @@

- include_tasks: _test_case_replicas.yml
vars:
expected_web_replicas: 0
expected_task_replicas: 0
expected_web_replicas: 1
expected_task_replicas: 1

####

Expand Down
4 changes: 2 additions & 2 deletions roles/installer/templates/deployments/task.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ metadata:
{{ lookup("template", "../common/templates/labels/common.yaml.j2") | indent(width=4) | trim }}
{{ lookup("template", "../common/templates/labels/version.yaml.j2") | indent(width=4) | trim }}
spec:
{% if task_replicas != '' and task_manage_replicas | bool %}
{% if task_replicas != '' and task_replicas|int != 0 and task_manage_replicas | bool %}
replicas: {{ task_replicas }}
{% elif replicas != '' and task_manage_replicas | bool %}
{% elif replicas != '' and replicas|int != 0 and task_manage_replicas | bool %}
replicas: {{ replicas }}
{% endif %}
selector:
Expand Down
4 changes: 2 additions & 2 deletions roles/installer/templates/deployments/web.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ metadata:
{{ lookup("template", "../common/templates/labels/common.yaml.j2") | indent(width=4) | trim }}
{{ lookup("template", "../common/templates/labels/version.yaml.j2") | indent(width=4) | trim }}
spec:
{% if web_replicas != '' and web_manage_replicas | bool %}
{% if web_replicas != '' and web_replicas|int != 0 and web_manage_replicas | bool %}
replicas: {{ web_replicas }}
{% elif replicas != '' and web_manage_replicas | bool %}
{% elif replicas != '' and replicas|int != 0 and web_manage_replicas | bool %}
replicas: {{ replicas }}
{% endif %}
selector:
Expand Down
Loading