Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Make cloud providers dynamic #15537
base: devel
Are you sure you want to change the base?
[WIP]Make cloud providers dynamic #15537
Changes from all commits
a9303ba
4129087
ea6f9a2
6199bd2
4330b29
ce9c764
7f1fd91
854d6f6
4ff9d21
010944d
ab09c9a
8ca5f40
cf38e53
74027bd
8c190a5
e6cab0a
62c0615
743f7b9
b3174bb
c099267
039355d
36dc7f7
a6907c6
aeb24a3
648e161
164bc61
549ce23
6c889b1
63bcfd4
f356cca
1f293b7
950bde1
bb4ffc0
41e224b
ff91727
6d5fce1
1c59e4b
ae7c83b
37a9dea
96009a7
3a5d452
788630f
4a0db49
7f88fa4
66cf64c
9f8c06e
c5b96c9
5e2a236
5a87544
3e07edd
7787f68
eaaafd5
a068839
72dd3dc
f8bb1b6
c8d9b8d
bdc7d22
c44bd64
22e9c3c
4c14b00
16a41d2
6cb7ebd
8addff4
5d56d2f
911c8f8
3670317
44c20d7
355f091
c4c23f9
89117bc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have these text explanations anywhere? Or do we need to have them in the plugins interfaces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been unable to locate the explanations in the repo, I think we may need them in the plugins interface. I will triple-check, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't found these in the moved-out plugins either. So yes, we should consider including this information in the plugins interface. We could temporarily put this mapping into the interfaces repo for now, or have it somewhere in serializers. I'm not sure where it's displayed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking into the test failures, it seems to me that my suspicion was likely right and this might need to be moved away from import-time invocation. And I'd try converting this to use
pytest-subtests
.