-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[AAP-34936] Manage Django Settings with Dynaconf #15702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
So how would the |
2211f8f
to
7cdfe26
Compare
598a36d
to
38598cc
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. 🚀 New features to boost your workflow:
|
@AlanCoding will not, this is going to be on phase 2 only. |
0981fdf
to
4a6f6e8
Compare
FYI, it looks like the awx-operator CI check failed. The AWX deployment by the operator itself was successful, but the job template failed. This may be related to the settings changes in this PR. I would next check that job templates run successfully in the AWX dev environment. If they do, then there are likely awx-operator changes needed around how we mount-in the settings.py file into the task and web pods. |
d482a87
to
0eb7b4e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
0eb7b4e
to
1efb08d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
@AlanCoding the error above is a validation that I explicitly added to replicate the following lines awx/awx/settings/production.py Lines 70 to 99 in 7d30dff
My logic was: If neither So it look like that is not the case right? |
The expectation is that
Help me talk that out a little better. Again, I can wave away corner cases here and presume that if not included_file or included_file == settings_file: Specifically, |
@AlanCoding this is logic from
From what I learned, split_settings keeps state of which files already loaded in the As I am removing split_settings, this logic is not applying anymore, as dynaconf tracks loaded files in a different way. |
1efb08d
to
5df4c0b
Compare
Hey, thanks. I saw some pushes and re-tested. From that, I can see this is making progress. Before, it failed on an
Here, I must apologize for some tech-debt on the AWX side. The |
@rooftopcellist re-running the awx-operator job to confirm the CI check is still not passing but building the dev environment off of the latest commit 5df4c0b, I am able to run the Demo Job Template successfully. |
@jessicamack I am running the dev environment locally, what are the steps for me to run the demo job template? |
@rochacbruno do you have the UI built? you should be able to view it on port 8043. if not you might need to run |
I executed the collectstatic inside the container and then restarted but I see "Oops... Looks like the UI wasn't properly built" |
@rochacbruno if you run |
ce606ff
to
9b939f7
Compare
Thanks @jessicamack it worked and Demo Job Template runs without problems on my local environment. @AlanCoding on the dev env, the DEFAULTS_SNAPSHOT is there and I compared with the keys present when running from devel branch and it is the same. Not sure why you are getting error that the key is not defined. |
9b939f7
to
ad2ea2c
Compare
Thanks @jessicamack @AlanCoding now it is working! api-schema test is failing but it seems to be also failing on other PRs |
7e8ad3c
to
b596859
Compare
I'm unclear on this failure
I'll restart it in case it's flaky |
We have identified the source of the failure for api-tests, and hope to have it fixed soon. Not an issue with this branch. |
Fix to that was merged in #15875, it should clear up after rebase |
Dynaconf is being added from DAB factory to load Django Settings
|
AAP-34936
New or Enhanced Feature
Settings now managed by Dynaconf.
NOTE: Currently depends on DAB ansible/django-ansible-base#689 to be merged.DOCS https://github.com/ansible/django-ansible-base/blob/devel/docs/lib/dynamic_config.md
and https://gist.github.com/rochacbruno/3779c7a6acf341b22ea7c26c9f4d023e