Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: use singular form ANSIBLE_COLLECTIONS_PATH #15841

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

Conversation

pb82
Copy link
Contributor

@pb82 pb82 commented Feb 19, 2025

SUMMARY

ANSIBLE_COLLECTIONS_PATHS has been deprecated in favour of the singular ANSIBLE_COLLECTIONS_PATH

[DEPRECATION WARNING]: ANSIBLE_COLLECTIONS_PATHS option, does not fit var 
naming standard, use the singular form ANSIBLE_COLLECTIONS_PATH instead. This 
feature will be removed from ansible-core in version 2.19. Deprecation warnings
can be disabled by setting deprecation_warnings=False in ansible.cfg.
ISSUE TYPE
  • Breaking Change
  • New or Enhanced Feature
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API
AWX VERSION
devel
ADDITIONAL INFORMATION

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.17%. Comparing base (8145de3) to head (ed492f6).

✅ All tests successful. No failed tests found.

❌ Your project check has failed because the head coverage (53.17%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (8145de3) and HEAD (ed492f6). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (8145de3) HEAD (ed492f6)
CI-GHA 8 7
pytest 5 4
OS-Linux 8 7

Copy link

@art-tapin art-tapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the replacement of ANSIBLE_COLLECTIONS_PATHS with ANSIBLE_COLLECTIONS_PATH by:

  1. Set up local AWX environment using Docker Compose
  2. Through AWX UI:
    • Created new test project with Git source
    • Used vmware_project repo that contains collection requirements (https://github.com/pb82/vmware_project)
    • Verified initial project sync completed successfully
    • Ran additional manual sync - also successful
  3. Results:
    • Both syncs completed without errors
    • No deprecation warnings about ANSIBLE_COLLECTIONS_PATHS appeared
    • Collection installation worked correctly with new variable name

Testing confirms the variable rename is working as expected and doesn't break existing functionality. LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants