AAP-39365 facts are unintentionally deleted when the inventory is modified during a job execution #15910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. 🚀 New features to boost your workflow:
|
AlanCoding
reviewed
Mar 31, 2025
AlanCoding
reviewed
Mar 31, 2025
AlanCoding
reviewed
Mar 31, 2025
djyasin
force-pushed
the
AAP_39365_Facts_are_unintentionally_deleted_when_the_inventory_is_modified_during_a_Job_execution
branch
3 times, most recently
from
19cea6d to
cf9a38c
Compare
AlanCoding
reviewed
Apr 7, 2025
AlanCoding
reviewed
Apr 7, 2025
AlanCoding
reviewed
Apr 7, 2025
AlanCoding
approved these changes
Apr 7, 2025
AlanCoding
reviewed
Apr 8, 2025
djyasin
force-pushed
the
AAP_39365_Facts_are_unintentionally_deleted_when_the_inventory_is_modified_during_a_Job_execution
branch
from
140805b to
cff5dd7
Compare
AlanCoding
reviewed
Apr 8, 2025
djyasin
force-pushed
the
AAP_39365_Facts_are_unintentionally_deleted_when_the_inventory_is_modified_during_a_Job_execution
branch
from
328d66c to
b6e57f9
Compare
…e undesired behaviour with fact cache Signed-off-by: onetti7 <[email protected]>
…e undesired behaviour with fact cache Signed-off-by: onetti7 <[email protected]>
Signed-off-by: onetti7 <[email protected]>
Signed-off-by: onetti7 <[email protected]>
djyasin
force-pushed
the
AAP_39365_Facts_are_unintentionally_deleted_when_the_inventory_is_modified_during_a_Job_execution
branch
from
3525f13 to
4bd99dc
Compare
AlanCoding
reviewed
Apr 10, 2025
tvo318
approved these changes
Apr 10, 2025
djyasin
force-pushed
the
AAP_39365_Facts_are_unintentionally_deleted_when_the_inventory_is_modified_during_a_Job_execution
branch
from
4bd99dc to
ffff1b8
Compare
Remove now unused line of code which was commented out by the contributor Revert "Remove now unused line of code which was commented out by the contributor" This reverts commit f1a056a.
…ecific to the particular slice when applicable Revise private_data_dir fixture to see if it improves code coverage Checked out awx/main/tests/unit/models/test_jobs.py in devel to see if it resolves git diff issue
Rename for loop from host in hosts to hosts in hosts_cahced and remove unneeded continue Revise finish_fact_cache to utilize inventory rather than hosts Remove local var hosts that was assigned but unused Revert change in start_fact_cache hosts_cached back to hosts Revise the way we are handling hosts_cached and joining the file Revert "Revise the way we are handling hosts_cached and joining the file" This reverts commit e6e3d2f. Reapply "Revise the way we are handling hosts_cached and joining the file" This reverts commit a42b7ae. Revert some of my changes to get back to a better working state Rename for loop to host in hosts_cached and remove unneeded continue Remove jobs job.get_hosts_for_fact_cache() from post run hook, fix if statement after continue block, and revise how we are calling hosts in finish for loop Add test_invalid_host_facts to test_jobs to increase code coverage Update method signature to use hosts_cached and updated other references to hosts in finish_facts_cached Rename hosts iterator to hosts_cached to agree with naming elsewhere Revise test_invalid_host_facts to get more code coverage Revise test_invalid_host_facts to increase codecov Revise test_pre_post_run_hook_facts_deleted_sliced to ensure we are hitting the assertionerror for code cov Revise mock_inventory.hosts. to hit assert failure Add revision of hosts and facts to force failure to satisfy code cov Fix failure in test_pre_post_run_hook_facts_deleted_sliced Add back for loop to create failures and add assert to hit them Remove hosts.iterator() from both start_fact_cache and finish_fact_cache Remove unused import of Queryset to satisfy api-lint Fix typo in docstring hasnot to has not Move hosts_cached.append(host) to outer loop in start_fact_cache Add class to help support cached hosts resolving host.name issue with hosts_cached
Remove fixture needed for local work only maybe Revert "Add class to help support cached hosts resolving host.name issue with hosts_cached" This reverts commit 99d998c.
djyasin
force-pushed
the
AAP_39365_Facts_are_unintentionally_deleted_when_the_inventory_is_modified_during_a_Job_execution
branch
from
ffff1b8 to
9de0763
Compare
…_when_the_inventory_is_modified_during_a_Job_execution
|
djulich
pushed a commit
to djulich/awx
that referenced
this pull request
Apr 13, 2025
…ified during a job execution (ansible#15910) * Added test_jobs.py to the model unit test folder in orther to show the undesired behaviour with fact cache Signed-off-by: onetti7 <[email protected]> * Added test_jobs.py to the model unit test folder in orther to show the undesired behaviour with fact cache Signed-off-by: onetti7 <[email protected]> * Solved undesired behaviour with fact_cache Signed-off-by: onetti7 <[email protected]> * Solved bug with slices Signed-off-by: onetti7 <[email protected]> * Remove unused imports Remove now unused line of code which was commented out by the contributor Revert "Remove now unused line of code which was commented out by the contributor" This reverts commit f1a056a. * Add back line that had been commented out as this line makes hosts specific to the particular slice when applicable Revise private_data_dir fixture to see if it improves code coverage Checked out awx/main/tests/unit/models/test_jobs.py in devel to see if it resolves git diff issue * Fix formatting in awx/main/tests/unit/models/test_jobs.py Rename for loop from host in hosts to hosts in hosts_cahced and remove unneeded continue Revise finish_fact_cache to utilize inventory rather than hosts Remove local var hosts that was assigned but unused Revert change in start_fact_cache hosts_cached back to hosts Revise the way we are handling hosts_cached and joining the file Revert "Revise the way we are handling hosts_cached and joining the file" This reverts commit e6e3d2f. Reapply "Revise the way we are handling hosts_cached and joining the file" This reverts commit a42b7ae. Revert some of my changes to get back to a better working state Rename for loop to host in hosts_cached and remove unneeded continue Remove jobs job.get_hosts_for_fact_cache() from post run hook, fix if statement after continue block, and revise how we are calling hosts in finish for loop Add test_invalid_host_facts to test_jobs to increase code coverage Update method signature to use hosts_cached and updated other references to hosts in finish_facts_cached Rename hosts iterator to hosts_cached to agree with naming elsewhere Revise test_invalid_host_facts to get more code coverage Revise test_invalid_host_facts to increase codecov Revise test_pre_post_run_hook_facts_deleted_sliced to ensure we are hitting the assertionerror for code cov Revise mock_inventory.hosts. to hit assert failure Add revision of hosts and facts to force failure to satisfy code cov Fix failure in test_pre_post_run_hook_facts_deleted_sliced Add back for loop to create failures and add assert to hit them Remove hosts.iterator() from both start_fact_cache and finish_fact_cache Remove unused import of Queryset to satisfy api-lint Fix typo in docstring hasnot to has not Move hosts_cached.append(host) to outer loop in start_fact_cache Add class to help support cached hosts resolving host.name issue with hosts_cached * Add live tests for ansible facts Remove fixture needed for local work only maybe Revert "Add class to help support cached hosts resolving host.name issue with hosts_cached" This reverts commit 99d998c. * Move hosts_cached.append(host) outside of try except * Move hosts_cached.append(host) to the beginning of start_fact_cache --------- Signed-off-by: onetti7 <[email protected]> Co-authored-by: onetti7 <[email protected]> Co-authored-by: Alan Rominger <[email protected]>
SammyEnigma
pushed a commit
to SammyEnigma/awx
that referenced
this pull request
Jun 2, 2025
…ified during a job execution (ansible#15910) * Added test_jobs.py to the model unit test folder in orther to show the undesired behaviour with fact cache Signed-off-by: onetti7 <[email protected]> * Added test_jobs.py to the model unit test folder in orther to show the undesired behaviour with fact cache Signed-off-by: onetti7 <[email protected]> * Solved undesired behaviour with fact_cache Signed-off-by: onetti7 <[email protected]> * Solved bug with slices Signed-off-by: onetti7 <[email protected]> * Remove unused imports Remove now unused line of code which was commented out by the contributor Revert "Remove now unused line of code which was commented out by the contributor" This reverts commit f1a056a. * Add back line that had been commented out as this line makes hosts specific to the particular slice when applicable Revise private_data_dir fixture to see if it improves code coverage Checked out awx/main/tests/unit/models/test_jobs.py in devel to see if it resolves git diff issue * Fix formatting in awx/main/tests/unit/models/test_jobs.py Rename for loop from host in hosts to hosts in hosts_cahced and remove unneeded continue Revise finish_fact_cache to utilize inventory rather than hosts Remove local var hosts that was assigned but unused Revert change in start_fact_cache hosts_cached back to hosts Revise the way we are handling hosts_cached and joining the file Revert "Revise the way we are handling hosts_cached and joining the file" This reverts commit e6e3d2f. Reapply "Revise the way we are handling hosts_cached and joining the file" This reverts commit a42b7ae. Revert some of my changes to get back to a better working state Rename for loop to host in hosts_cached and remove unneeded continue Remove jobs job.get_hosts_for_fact_cache() from post run hook, fix if statement after continue block, and revise how we are calling hosts in finish for loop Add test_invalid_host_facts to test_jobs to increase code coverage Update method signature to use hosts_cached and updated other references to hosts in finish_facts_cached Rename hosts iterator to hosts_cached to agree with naming elsewhere Revise test_invalid_host_facts to get more code coverage Revise test_invalid_host_facts to increase codecov Revise test_pre_post_run_hook_facts_deleted_sliced to ensure we are hitting the assertionerror for code cov Revise mock_inventory.hosts. to hit assert failure Add revision of hosts and facts to force failure to satisfy code cov Fix failure in test_pre_post_run_hook_facts_deleted_sliced Add back for loop to create failures and add assert to hit them Remove hosts.iterator() from both start_fact_cache and finish_fact_cache Remove unused import of Queryset to satisfy api-lint Fix typo in docstring hasnot to has not Move hosts_cached.append(host) to outer loop in start_fact_cache Add class to help support cached hosts resolving host.name issue with hosts_cached * Add live tests for ansible facts Remove fixture needed for local work only maybe Revert "Add class to help support cached hosts resolving host.name issue with hosts_cached" This reverts commit 99d998c. * Move hosts_cached.append(host) outside of try except * Move hosts_cached.append(host) to the beginning of start_fact_cache --------- Signed-off-by: onetti7 <[email protected]> Co-authored-by: onetti7 <[email protected]> Co-authored-by: Alan Rominger <[email protected]>
stevensonmichel
pushed a commit
that referenced
this pull request
Jul 10, 2025
…ified during a job execution (#15910) (#6905) * Added test_jobs.py to the model unit test folder in orther to show the undesired behaviour with fact cache * Added test_jobs.py to the model unit test folder in orther to show the undesired behaviour with fact cache * Solved undesired behaviour with fact_cache * Solved bug with slices * Remove unused imports Remove now unused line of code which was commented out by the contributor Revert "Remove now unused line of code which was commented out by the contributor" This reverts commit f1a056a. * Add back line that had been commented out as this line makes hosts specific to the particular slice when applicable Revise private_data_dir fixture to see if it improves code coverage Checked out awx/main/tests/unit/models/test_jobs.py in devel to see if it resolves git diff issue * Fix formatting in awx/main/tests/unit/models/test_jobs.py Rename for loop from host in hosts to hosts in hosts_cahced and remove unneeded continue Revise finish_fact_cache to utilize inventory rather than hosts Remove local var hosts that was assigned but unused Revert change in start_fact_cache hosts_cached back to hosts Revise the way we are handling hosts_cached and joining the file Revert "Revise the way we are handling hosts_cached and joining the file" This reverts commit e6e3d2f. Reapply "Revise the way we are handling hosts_cached and joining the file" This reverts commit a42b7ae. Revert some of my changes to get back to a better working state Rename for loop to host in hosts_cached and remove unneeded continue Remove jobs job.get_hosts_for_fact_cache() from post run hook, fix if statement after continue block, and revise how we are calling hosts in finish for loop Add test_invalid_host_facts to test_jobs to increase code coverage Update method signature to use hosts_cached and updated other references to hosts in finish_facts_cached Rename hosts iterator to hosts_cached to agree with naming elsewhere Revise test_invalid_host_facts to get more code coverage Revise test_invalid_host_facts to increase codecov Revise test_pre_post_run_hook_facts_deleted_sliced to ensure we are hitting the assertionerror for code cov Revise mock_inventory.hosts. to hit assert failure Add revision of hosts and facts to force failure to satisfy code cov Fix failure in test_pre_post_run_hook_facts_deleted_sliced Add back for loop to create failures and add assert to hit them Remove hosts.iterator() from both start_fact_cache and finish_fact_cache Remove unused import of Queryset to satisfy api-lint Fix typo in docstring hasnot to has not Move hosts_cached.append(host) to outer loop in start_fact_cache Add class to help support cached hosts resolving host.name issue with hosts_cached * Add live tests for ansible facts Remove fixture needed for local work only maybe Revert "Add class to help support cached hosts resolving host.name issue with hosts_cached" This reverts commit 99d998c. * Move hosts_cached.append(host) outside of try except * Move hosts_cached.append(host) to the beginning of start_fact_cache --------- Signed-off-by: onetti7 <[email protected]> Co-authored-by: onetti7 <[email protected]> Co-authored-by: Alan Rominger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This change fixes facts are unintentionally deleted when the inventory is modified during a job execution
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION