-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the docker-compose serving #694
base: devel
Are you sure you want to change the base?
Conversation
@@ -7,7 +7,7 @@ chmod-socket = 660 | |||
vacuum = true | |||
|
|||
# Log to stdout | |||
logto = /dev/stdout | |||
# logto = /dev/stdout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seemed to cause the problem related to seeking, that it was logging to a file that didn't allow seeking (which was /dev/stdout). It still logged without this, and I think we weren't really getting uwsgi logs without it, maybe.
@@ -49,3 +49,6 @@ tools/generated/* | |||
|
|||
# generated ssl certs | |||
compose/ingress/certs/* | |||
|
|||
# static files | |||
test_app/static_collected/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put this in /static/ first, but someone had already put 1 file in that folder. Using a different dir requires more settings to manage that but is then non-conflicting with this existing file. I tested it and things are working.
@@ -12,6 +12,7 @@ echo "settings.DATABASE ..." | |||
$PYTHON manage.py shell -c 'from django.conf import settings; print(settings.DATABASES)' | |||
|
|||
$PYTHON manage.py migrate | |||
$PYTHON manage.py collectstatic --clear --noinput |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The --clear
option would blow away the existing file in the test_app/static/ dir when I had it there, but using the new folder resolves this, so that'll only contain collected static files.
|
Can we get a list of the problems that are supposed to be fixed by this PR? |
|
@AlanCoding since this is just dev environment we will let you all review and and merge it. If you need anything from platform services please let us know. |
This fixes a grab bag of problems for me, but still doesn't get it to usability. The static files makes this render.
And then the other changes address the errors in logs
and
This is addressed by the uwsgi config file change, and to the startup script.
I think this is some progress, but unfortunately, I'm still blocked on using the docker-compose environment as I get a CSRF error when trying to log in.