Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAP-40103 Adding app_url to OAuth Application API #699

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

tyraziel
Copy link
Contributor

AAP-40103 Adding app_url to OAuth Application API

Description

  • What is being changed? Adding app_url to OAuth Application API
  • Why is this change needed? Needed for gateway UI to be able to have a clickable link to the OAuth Application
  • How does this change address the issue? Implements the desired state.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test update
  • Refactoring (no functional changes)
  • Development environment change
  • Configuration change

Self-Review Checklist

  • I have performed a self-review of my code
  • I have added relevant comments to complex code sections
  • I have updated documentation where needed
  • I have considered the security impact of these changes
  • I have considered performance implications
  • I have thought about error handling and edge cases
  • I have tested the changes in my local environment

Testing Instructions

Go to the API for gateway after logging in - api/gateway/v1/applications/ -- scroll down to see the Application URL text box, and create applications with Application URL, with no Application URL, update applications with different Application URLs and try malformed URLs for the Application URL text box.

Prerequisites

Steps to Test

  1. Log into API
  2. Browse to v1/applications
  3. Test various applications and updates to applications with differing Application URLs including malformed ones to ensure validation takes place.

Expected Results

Applications should have app_url in the response body with the updates. Malformed URLs for Application URL should result in an error message accompanying the HTTP 400.

Additional Context

Required Actions

  • Requires documentation updates
  • Requires downstream repository changes
  • Requires infrastructure/deployment changes
  • Requires coordination with other teams
    UI Team, Gateway Team
  • Blocked by PR/MR: #XXX

Screenshots/Logs

@tyraziel tyraziel force-pushed the AAP-40103_add_app_url_to_oauth_applications branch 6 times, most recently from b92a895 to 0855b28 Compare February 19, 2025 14:11
@tyraziel tyraziel force-pushed the AAP-40103_add_app_url_to_oauth_applications branch from 0855b28 to be91cd7 Compare February 25, 2025 14:57
@tyraziel tyraziel force-pushed the AAP-40103_add_app_url_to_oauth_applications branch from f2cf48a to af95885 Compare February 25, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants