Skip to content

AAP-56032 Do not run feature flag logic for partial migrations #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlanCoding wants to merge 2 commits into
base: devel
Choose a base branch
from
+10 −0
Open

AAP-56032 Do not run feature flag logic for partial migrations #918

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55ca7dd
Do not purge feature flags when migrations are not fully applied
AlanCoding Jan 16, 2026
3c3a27c
Do not run feature flag post_migration stuff for partial migrations
AlanCoding Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ansible_base/feature_flags/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
from django.core.exceptions import ValidationError
from flags.sources import get_flags

from ansible_base.lib.utils.db import migrations_are_complete

logger = logging.getLogger('ansible_base.feature_flags.utils')


Expand Down Expand Up @@ -55,6 +57,10 @@ def load_feature_flags():
from ansible_base.resource_registry.models import Resource
from ansible_base.resource_registry.signals.handlers import no_reverse_sync

if not migrations_are_complete():
logger.debug('Not running load_feature_flags logic because migrations not incomplete')
return

feature_flags_model = apps.get_model('dab_feature_flags', 'AAPFlag')
for flag in feature_flags_list():
try:
Expand Down Expand Up @@ -88,6 +94,10 @@ def purge_feature_flags():
"""
from ansible_base.resource_registry.signals.handlers import no_reverse_sync

if not migrations_are_complete():
logger.debug('Not running purge_feature_flags logic because migrations not incomplete')
return

all_flags = apps.get_model('dab_feature_flags', 'AAPFlag').objects.all()
for flag in all_flags:
found = False
Expand Down