Add typing to inform spectacular of field details#920
Open
AlanCoding wants to merge 1 commit intoansible:develfrom
Open
Add typing to inform spectacular of field details#920AlanCoding wants to merge 1 commit intoansible:develfrom
AlanCoding wants to merge 1 commit intoansible:develfrom
Conversation
|
From the PR description: But this output includes debug and the generated openapi spec. In the output it summarizes findings. The bulk of the warnings are for missing OpenApiAuthenticationExtension for test-app that could be ignored. So yes there are things that could be fixed but it's not 20k things. |
9938ac8 to
6d7747e
Compare
|
DVCS PR Check Results: Could not find JIRA key(s) in PR title, branch name, or commit messages |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Working on #919
Saw
for later sanity
after this change the warning goes away. And to wrap this up:
formally addresses 1 warning. How many are left? For posterity:
Type of Change
Self-Review Checklist
Note
Adds explicit typing to RBAC serializers to aid drf-spectacular and remove a schema warning.
TypedDicttypesRoleDefinitionSummaryandAssignmentSummaryinserializers.pysummarize_role_definition,summarize_assignment_list, andget_object_role_assignmentsSerializerMethodFields forobject_role_assignmentsandintermediary_rolesget_intermediary_roles(self, assignment: RoleUserAssignment) -> list[AssignmentSummary], addressing the prior unresolved type hint warningWritten by Cursor Bugbot for commit 6d7747e. This will update automatically on new commits. Configure here.