Skip to content

[AAP-72703] Update FEATURE_DASHBOARD_COLLECTION_ENABLED flag toggle type#988

Merged
bhavenst merged 1 commit intoansible:develfrom
cshiels-ie:AAP-72703-dashboard-flag-install-time
Apr 29, 2026
Merged

[AAP-72703] Update FEATURE_DASHBOARD_COLLECTION_ENABLED flag toggle type#988
bhavenst merged 1 commit intoansible:develfrom
cshiels-ie:AAP-72703-dashboard-flag-install-time

Conversation

@cshiels-ie
Copy link
Copy Markdown
Contributor

@cshiels-ie cshiels-ie commented Apr 29, 2026

Changed the toggle type of the FEATURE_DASHBOARD_COLLECTION_ENABLED feature flag from run-time to install-time in feature_flags.yaml. Updated the file hash in the migration script 0005_manual_20260417.py to reflect this change.


Note

Low Risk
Small config metadata change plus hash update; no logic changes beyond restricting when the flag can be toggled.

Overview
Updates the FEATURE_DASHBOARD_COLLECTION_ENABLED feature flag definition to be install-time (was run-time), changing when it can be toggled.

Refreshes the tracked FileHash in 0005_manual_20260417.py to match the updated feature_flags.yaml content.

Reviewed by Cursor Bugbot for commit 5c9c8f0. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Chores
    • Updated how the dashboard collection feature is configured. The feature is now set during installation rather than being adjustable afterward, simplifying deployment configuration processes.

Changed the toggle type of the `FEATURE_DASHBOARD_COLLECTION_ENABLED` feature flag from `run-time` to `install-time` in `feature_flags.yaml`. Updated the file hash in the migration script `0005_manual_20260417.py` to reflect this change.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 7983ccba-42b5-4cbb-91fb-690a477dea10

📥 Commits

Reviewing files that changed from the base of the PR and between 28d9875 and 5c9c8f0.

📒 Files selected for processing (2)
  • ansible_base/feature_flags/definitions/feature_flags.yaml
  • ansible_base/feature_flags/migrations/0005_manual_20260417.py

📝 Walkthrough

Walkthrough

The FEATURE_DASHBOARD_COLLECTION_ENABLED feature flag's toggle_type is changed from run-time to install-time, and a Django migration file's FileHash metadata is updated. Both are minimal configuration changes affecting when the feature flag takes effect.

Changes

Cohort / File(s) Summary
Feature Flag Configuration
ansible_base/feature_flags/definitions/feature_flags.yaml
Changed FEATURE_DASHBOARD_COLLECTION_ENABLED toggle type from run-time to install-time, making the feature configurable at installation rather than runtime.
Migration Metadata
ansible_base/feature_flags/migrations/0005_manual_20260417.py
Updated FileHash comment metadata; no migration logic or operations modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: updating the FEATURE_DASHBOARD_COLLECTION_ENABLED flag's toggle type from run-time to install-time.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

DVCS PR Check Results:

PR appears valid (JIRA key(s) found)

@sonarqubecloud
Copy link
Copy Markdown

@bhavenst bhavenst merged commit d4ea85e into ansible:devel Apr 29, 2026
21 checks passed
@cshiels-ie cshiels-ie deleted the AAP-72703-dashboard-flag-install-time branch April 29, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants