Usage report tab for indirect nodes#167
Closed
ShaiahWren wants to merge 7 commits intoansible:develfrom
Closed
Conversation
ShaiahWren
force-pushed
the
usage-report-tab
branch
from
2465474 to
a02851a
Compare
…report 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
ShaiahWren
force-pushed
the
usage-report-tab
branch
from
a02851a to
529282b
Compare
Ladas
reviewed
Jul 16, 2025
| return df.astype(types) | ||
|
|
||
| def summarize_merged_dataframes(self, df, columns, operations={}): | ||
| df_copy = df.copy() |
Contributor
There was a problem hiding this comment.
why is copy needed? it will double in memory everytime you copy, does pandas throw warnings it should be copied?
Contributor
|
@ShaiahWren hm, it is doing a lot of changes and refactorings. Can you try with more directed change like we were able to generate? That basically changed just few functions to add the new sheet? |
Contributor
Author
|
Closing in favor of #169 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[AAP-48357]
##Description
An infrastructure summary of indirect nodes in new tab "Usage Report" MVP. The On-Premise infrastructure is included for now, although it can be removed if it cannot be used here or anywhere else. Further testing is needed. The next step will be to generate tarballs of broken data and test thoroughly.
Testing
ENV VARS:
export METRICS_UTILITY_SHIP_PATH=/Users/semighdo/work/metrics-utility/metrics_utility/test/test_data
export METRICS_UTILITY_SHIP_TARGET="directory"
export METRICS_UTILITY_OPTIONAL_CCSP_REPORT_SHEETS="ccsp_summary,indirectly_managed_nodes"
export METRICS_UTILITY_REPORT_TYPE="CCSPv2"
Run build report:
uv run ./manage.py build_report --since=2025-02-25 --until=2025-02-26 --force
Expected Results
Resulting xlsx should contain the new tab "Usage Report" showing infrastructure breakdown
Required Actions
Self-Review Checklist
Code Quality
- If updates are required in the handbook, create a separate PR for the handbook repo.
Notes for Reviewers
Add any additional context or instructions for reviewers here - for example screenshots if needed.