cli - use library.storage#243
Draft
himdel wants to merge 1 commit intoansible:develfrom
Draft
Conversation
ae2a55e to
4ec054d
Compare
Remove S3Handler, replace with StorageS3 upload_file caught errors, returned None on success, False on fail download_file caught errors, returned True on success, False on fail storage get/put doesn't catch, and doesn't return anything but, users of `upload_file`: * `PackageS3` - doesn't catch, ignores return * gather will now fail if it fails to save the result * `ReportSaverS3` - catches right outside, ignores return users of `download_file`: * `ExtractorS3` - catches right outside, ignores return * we no longer try to process_tarballs on download failure update ExtractorS3, PackageS3, ReportSaverS3 to use StorageS3 instead of S3Handler ExtractorS3 - try -> get -> tempdir -> unpack Extractor - align ExtractorDirectory, ExtractorS3, both using storage directory uses ship_path as the base path for storage, so we use data/Y/m/d/ as the path prefix, relative to base path s3 uses ship_path as part of the path prefix, eg ship_path/data/Y/m/d/ Issue: AAP-54345
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: AAP-54345 / AAP-57129
Implements
metrics_utility.library.storage-StorageS3,StorageDirectory,StorageCRC,StorageCRCMutualAnd makes extractors, report savers and packagers use it.
wip - add paths test for storagedirectory,
clean up in Extractor/ReportSaver/Packager
move crc logic from 2f15564
FIXME: rebase after #246