Adding an example of 'date' in the README as it is required. Otherwise, it will fail #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g as date is required
|
|
@art-tapin @Ladas I made this slight change as I was following the "new" README and I was not able to properly execute renewal guidance report. Please review! |
|
We might want to revert #61 (or, parts of it) The new README is missing most of the variables we need, and calling a convenience script meant for dev testing only. Also, |
larrymou9
changed the title
Ladas
reviewed
Feb 18, 2025
| export METRICS_UTILITY_REPORT_TYPE=RENEWAL_GUIDANCE | ||
| python manage.py build_report --since=12months --ephemeral=1month | ||
| # Set extra ENV VARs for report generation purposes | ||
| export METRICS_UTILITY_SHIP_TARGET=controller_db |
There was a problem hiding this comment.
based on above steps, this example should be generating CCSP report, not renewal guidance?
(because renewal guidance doesn't need to call the collector step now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't add a date, we will end up the following error.
Traceback (most recent call last): File "/root/metrics-utility/manage.py", line 6, in <module> manage() File "/root/metrics-utility/metrics_utility/__init__.py", line 28, in manage utility.execute() File "/root/metrics-utility/metrics_utility/management_utility.py", line 58, in execute self.fetch_command(subcommand).run_from_argv(self.argv) File "/var/lib/awx/venv/awx/lib64/python3.11/site-packages/django/core/management/base.py", line 412, in run_from_argv self.execute(*args, **cmd_options) File "/var/lib/awx/venv/awx/lib64/python3.11/site-packages/django/core/management/base.py", line 458, in execute output = self.handle(*args, **options) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/root/metrics-utility/metrics_utility/management/commands/build_report.py", line 124, in handle extra_params=extra_params).create() ^^^^^^^^ File "/root/metrics-utility/metrics_utility/automation_controller_billing/dataframe_engine/factory.py", line 26, in create return (self._get_db_dataframe_host_metric_usage().build_dataframe(),) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/root/metrics-utility/metrics_utility/automation_controller_billing/dataframe_engine/db_dataframe_host_metric.py", line 24, in build_dataframe for data in self.extractor.iter_batches(): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ TypeError: ExtractorDirectory.iter_batches() missing 1 required positional argument: 'date'So I have added this in the readme as an example so that people can run it without these problems