Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAP-38819] - Setting up pytest + S3 (Minio) + example test #71

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Feb 19, 2025

Issue: AAP-38819
Closes #57

I was testing #57 after #52 by adding postgres to the mix,
and managed to get it working (I think :))

cc @msmagnanijr
This is your #57 rebased on top of current devel,, with a commit adding postgres, switching to quay repositories, and working around permission issues with uv.

gather_automation_controller_billing_data runs successfully now :)


What is being changed?

  • Minio setup for local and CI testing.
  • Addition of an initial test scenario to validate CCSPv2 report generation with S3 backend.
  • Integration with pytest to run automated tests using Minio as a simulated backend.

Why is this change needed?

  • Enables testing of metrics-utility S3 storage functionality without relying on an external environment.
  • Facilitates test automation in the CI pipeline.
  • Ensures that report generation works correctly with the S3 backend before full implementation.

How does this change address the issue?

  • Uses Minio as a local S3 backend for testing.
  • Defines the necessary setup to run locally and in CI.
  • Implements an initial test case covering CCSPv2 report generation.

msmagnanijr and others added 3 commits February 19, 2025 20:50
…v issues

and move schemas around to keep them in tools

uv had trouble installing things when there already was a .venv, and building things because the new image runs with a 1001 user
copying into a tmpfs
Copy link
Collaborator

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. 👍

@himdel himdel changed the title WIP - [AAP-39919] - Setting up pytest + S3 (Minio) + example test WIP - [AAP-38819] - Setting up pytest + S3 (Minio) + example test Feb 20, 2025
@himdel himdel changed the title WIP - [AAP-38819] - Setting up pytest + S3 (Minio) + example test [AAP-38819] - Setting up pytest + S3 (Minio) + example test Feb 26, 2025
@himdel himdel marked this pull request as ready for review February 26, 2025 11:45
@himdel
Copy link
Collaborator Author

himdel commented Feb 26, 2025

Merging to get #72 unblocked,
will follow up by moving the s3 test alongside the existing pytest tests

@himdel himdel merged commit b6879b0 into ansible:devel Feb 26, 2025
5 checks passed
@himdel himdel deleted the pr57 branch February 26, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants