add cjis to compliance demo #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jce-redhat
requested changes
Feb 20, 2024
linux/cjis-prerequisites.yml
Outdated
| @@ -0,0 +1,22 @@ | |||
| --- | |||
| # The CJIS role seems to assume these packages are installed and the | |||
There was a problem hiding this comment.
@l3acon i haven't tested this yet, but i took a look at the CJIS role and i believe you won't need to install and enable firewalld and NetworkManager if the following variables get set:
service_firewalld_enabled: false
firewalld_sshd_port_enabled: false
these can be added to the LINUX / Multi-profile Compliance job template as long as the other CaC roles don't use variables of the same name.
linux/compliance-enforce.yml
Outdated
Comment on lines
13
to
17
| - name: Include prerequisites for cjis profile | ||
| ansible.builtin.include_tasks: | ||
| file: cjis-prerequisites.yml | ||
| when: compliance_profile == 'cjis' | ||
|
|
There was a problem hiding this comment.
if you add "cjis" to the survey spec for the "LINUX / Multi-profile compliance" job template definition, you shouldn't need to add this separate task for calling the CJIS role.
jce-redhat
approved these changes
Mar 3, 2024
|
Yay thanks @jce-redhat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be fairly simple, though I had some issues during testing. On RHEL7 I encountered jobs that failed without any error messages. I would normally chalk it up to the random gremlins but it happened more than once. Maybe @jce-redhat or someone has seen something similar?
Anyway, this at least worked once on rhel7 and rhel8.