Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OCP-CNV patching demo #140

Merged
merged 31 commits into from
Jun 11, 2024
Merged

Add OCP-CNV patching demo #140

merged 31 commits into from
Jun 11, 2024

Conversation

l3acon
Copy link
Collaborator

@l3acon l3acon commented Apr 12, 2024

This should at least be close to ready to use.

@l3acon
Copy link
Collaborator Author

l3acon commented Apr 18, 2024

To do's

  • take out machine credential
  • check out if RHEL VM entitlements can be automatic
  • add wait_for to end of provision of VM
    This is more complex than originally thought. We rely on the inventory plugin to set ansible_host, thus we must run the inventory sync first to determine a host to check against SSH being up for. My simple solution to this is simply run the inventory sync twice. ¯_(ツ)_/¯
  • fix cnv-inventory credential type to have descriptions the same as OCP type
  • timing of VM creation & post CNV operator install, chris ran into an issue where the automation tried to create the VM but the images hadn't pulled yet, so they became stale and never provisioned

@l3acon
Copy link
Collaborator Author

l3acon commented Jun 5, 2024

I have found solutions for both of the timing issues:

  • For validating operator install, we can repeatedly try to provision a VM, when it finally succeeds the operator is finished initializing and ready.
  • For the inventory sync issue, there is a module, kubevirt.vm_info that can be used to wait for a VM to be in the running state.

Additionally, I discussed with both OCP and RHEL SMEs about subscribing RHEL VMs running on OCP-V. There does not seem to be a more elegant method than using activation keys (or a manifest of some kind).

After what feels like a lifetime ago, I believe this is finally ready for review.

Copy link
Collaborator

@willtome willtome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need to wait for a new EE build from @cloin before merging?

@l3acon
Copy link
Collaborator Author

l3acon commented Jun 11, 2024

@IPvSean already merged ee-builds for us, however it seems the github action did not succeed from Sean's merge https://github.com/cloin/ee-builds/actions/runs/9454222805/job/26041308031#step:7:22 and that is causing the inventory bug @willtome discovered.

@l3acon
Copy link
Collaborator Author

l3acon commented Jun 11, 2024

The new image built. I am going to do a clean slate run through and merge if there are no issues.

@l3acon l3acon merged commit 40807f1 into ansible:main Jun 11, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants