chore: address multiple node dependency misconfigurations#2365
Merged
Conversation
15 tasks
62bf5e8 to
cb7ccb5
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the dependency management tooling by replacing the unmaintained depcheck tool with knip, removes unused chalk utilities from the test suite (in preparation for vitest migration), and cleans up other unused dependencies identified by knip.
Key changes:
- Replaces
depcheckwithknipfor dependency checking - Removes chalk-based console wrappers from test helper utilities
- Adds explicit dependencies that were previously resolved transitively (vscode-languageserver-protocol, vscode-languageserver-types, vscode-jsonrpc)
- Removes unused type definitions (@types/glob, @types/uuid, @types/minimatch, @types/selenium-webdriver)
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Adds knip and electron packages; removes depcheck, yarn-audit-fix, and associated transitive dependencies like @babel/traverse, depcheck-related packages, and ora dependencies |
| package.json | Removes unused devDependencies (@types/glob, @types/uuid, @types/minimatch, @types/selenium-webdriver, depcheck, yarn-audit-fix, @vscode/test-electron) and adds knip, electron, and @types/semver; adds knip script |
| packages/ansible-language-server/package.json | Removes unused @types packages (@types/glob, @types/uuid) and adds explicit dependencies that were previously transitive (vscode-languageserver-protocol, vscode-languageserver-types, vscode-jsonrpc) |
| packages/ansible-language-server/test/helper.ts | Removes chalk import and custom console wrappers with colored output, keeping only basic console export |
| knip.ts | New configuration file for knip tool with workspace-specific settings |
| Taskfile.yml | Updates deps task to use knip instead of depcheck |
| .pre-commit-config.yaml | Updates hook from depcheck to knip |
| .depcheckrc.yml | Removes deprecated depcheck configuration file |
| .config/dictionary.txt | Updates spellcheck dictionary to remove depcheck and add knip |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cb7ccb5 to
91da8cd
Compare
91da8cd to
bdf7d37
Compare
bdf7d37 to
582fcb6
Compare
- replace unmaintained depcheck with knip - remove use of chalk on als testing as we will switch to vitest - remove other unused dependencies as reported by knip - disable LS test that seems to be broken
582fcb6 to
83a908b
Compare
Closed
2 tasks
This was
unlinked from
issues
Dec 9, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: AAP-57251