Skip to content

chore: address multiple node dependency misconfigurations#2365

Merged
ssbarnea merged 1 commit intomainfrom
chore/depcheck
Dec 9, 2025
Merged

chore: address multiple node dependency misconfigurations#2365
ssbarnea merged 1 commit intomainfrom
chore/depcheck

Conversation

@ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Dec 8, 2025

  • replace unmaintained depcheck with knip
  • remove use of chalk on als testing as we will switch to vitest
  • remove other unused dependencies as reported by knip

Related: AAP-57251

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the dependency management tooling by replacing the unmaintained depcheck tool with knip, removes unused chalk utilities from the test suite (in preparation for vitest migration), and cleans up other unused dependencies identified by knip.

Key changes:

  • Replaces depcheck with knip for dependency checking
  • Removes chalk-based console wrappers from test helper utilities
  • Adds explicit dependencies that were previously resolved transitively (vscode-languageserver-protocol, vscode-languageserver-types, vscode-jsonrpc)
  • Removes unused type definitions (@types/glob, @types/uuid, @types/minimatch, @types/selenium-webdriver)

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
yarn.lock Adds knip and electron packages; removes depcheck, yarn-audit-fix, and associated transitive dependencies like @babel/traverse, depcheck-related packages, and ora dependencies
package.json Removes unused devDependencies (@types/glob, @types/uuid, @types/minimatch, @types/selenium-webdriver, depcheck, yarn-audit-fix, @vscode/test-electron) and adds knip, electron, and @types/semver; adds knip script
packages/ansible-language-server/package.json Removes unused @types packages (@types/glob, @types/uuid) and adds explicit dependencies that were previously transitive (vscode-languageserver-protocol, vscode-languageserver-types, vscode-jsonrpc)
packages/ansible-language-server/test/helper.ts Removes chalk import and custom console wrappers with colored output, keeping only basic console export
knip.ts New configuration file for knip tool with workspace-specific settings
Taskfile.yml Updates deps task to use knip instead of depcheck
.pre-commit-config.yaml Updates hook from depcheck to knip
.depcheckrc.yml Removes deprecated depcheck configuration file
.config/dictionary.txt Updates spellcheck dictionary to remove depcheck and add knip

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- replace unmaintained depcheck with knip
- remove use of chalk on als testing as we will switch to vitest
- remove other unused dependencies as reported by knip
- disable LS test that seems to be broken
@ssbarnea ssbarnea linked an issue Dec 9, 2025 that may be closed by this pull request
2 tasks
This was unlinked from issues Dec 9, 2025
@ssbarnea ssbarnea merged commit 5dcc652 into main Dec 9, 2025
14 checks passed
@ssbarnea ssbarnea deleted the chore/depcheck branch December 9, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants