chore: fix detection of lightspeed credentials on GHA#2600
chore: fix detection of lightspeed credentials on GHA#2600
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts CI and Selenium test utilities to improve how Lightspeed credentials are sourced in GitHub Actions (preferring pre-existing environment variables and falling back to secrets), and adds local venv folders to .gitignore.
Changes:
- Update
task ui-seleniumstep in CI to use${{ env.* || secrets.* }}forLIGHTSPEED_API_ENDPOINTandLIGHTSPEED_USER. - Tighten
sso_auth_flowparameter types/defaults for username/password. - Ignore
.venvdirectories in git.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test/selenium/utils/ui_utils.py |
Updates sso_auth_flow signature defaults/types for Lightspeed credentials. |
.gitignore |
Adds .venv to ignored paths. |
.github/workflows/ci.yaml |
Prefers existing env vars for Lightspeed endpoint/user, falls back to secrets for CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| username: str = LIGHTSPEED_USER, | ||
| password: str = LIGHTSPEED_PASSWORD, | ||
| *, |
There was a problem hiding this comment.
sso_auth_flow accepts username/password parameters, but the password argument is effectively ignored because it gets overwritten inside the function (password = LIGHTSPEED_PASSWORD). This makes it impossible to override credentials via arguments (and the docstring says these args are used for authentication). Consider either (a) using the passed-in args as the source of truth (falling back to env only when empty), or (b) removing the unused password parameter to avoid a misleading API.
a356222 to
001580f
Compare
001580f to
79c253a
Compare
79c253a to
abce363
Compare
abce363 to
f5645e3
Compare
f5645e3 to
8825d2c
Compare
8825d2c to
4659354
Compare
4659354 to
15440f1
Compare
Uh oh!
There was an error while loading. Please reload this page.