Implement checking for nested alias content #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiuka
force-pushed
the
nested_aliases
branch
from
248050a to
b32e547
Compare
|
I hope I find time this weekend to review this. Sorry for the long delay.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to API
https://docs.opnsense.org/development/api/core/firewall.html
Description
Content validation was disabled for
hostandnetworkaliases to allow using nested values. This patch uses the already fetched list of aliases to validate nested entries forpost,hostandnetwork.Further the host validation has been improved and some tests added.