-
Notifications
You must be signed in to change notification settings - Fork 0
Allow table_guid to be None when searching for and deleting list items #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #417 +/- ##
==========================================
+ Coverage 99.58% 99.61% +0.02%
==========================================
Files 4 4
Lines 726 778 +52
==========================================
+ Hits 723 775 +52
Misses 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Andy-Grigg
commented
May 8, 2025
…into feat/allow-optional-table-guid
ludovicsteinbach
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #409
Allow
table_guid
to be set toNone
when instantiating aRecordListItem
object. Document the conditions under which it is permissible to set the guid toNone
and validate that it is not set toNone
when not permitted, i.e. when adding items to a list.It's not possible to give
table_guid
a default value ofNone
without re-ordering the arguments, becauserecord_history_guid
is not optional. I have therefore documented the type explicitly asstr | None
, to indicate that it can be provided as either a string or None, but must be provided as one of these values.If a
RecordListItem
is empty and it is passed to theadd_items_to_list
method, raise aValueError
. It is unfortunate that we cannot raise the exception earlier, but we don't know what theRecordListItem
will be used for when it is instantiated.