Skip to content

REFACTOR: Move internal files to a new directory#5910

Merged
Samuelopez-ansys merged 21 commits intomainfrom
refactor/move_files
Mar 14, 2025
Merged

REFACTOR: Move internal files to a new directory#5910
Samuelopez-ansys merged 21 commits intomainfrom
refactor/move_files

Conversation

@Samuelopez-ansys
Copy link
Copy Markdown
Member

@Samuelopez-ansys Samuelopez-ansys commented Mar 13, 2025

Description

Generic directory has grown the last few years, and this PR is moving the files that are used internally in PyAEDT, and should not be used by the user.

Issue linked

Issue #5504

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions Bot added documentation Improvements or additions to documentation testing Anything related to testing labels Mar 13, 2025
Copy link
Copy Markdown
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initiative @Samuelopez-ansys ! Indeed the scope of this generic folder increased over time.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 97.29730% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.94%. Comparing base (463b124) to head (801b240).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5910      +/-   ##
==========================================
- Coverage   84.94%   84.94%   -0.01%     
==========================================
  Files         162      162              
  Lines       62305    62307       +2     
==========================================
  Hits        52926    52926              
- Misses       9379     9381       +2     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread doc/source/cheatsheet/cheat_sheet.qmd
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) March 14, 2025 14:03
Copy link
Copy Markdown
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit c82ca70 into main Mar 14, 2025
47 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the refactor/move_files branch March 14, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants