Skip to content

REFACTOR: Delete ML patch class#5916

Merged
Samuelopez-ansys merged 6 commits intomainfrom
refactor/remove_patch_ML
Mar 14, 2025
Merged

REFACTOR: Delete ML patch class#5916
Samuelopez-ansys merged 6 commits intomainfrom
refactor/remove_patch_ML

Conversation

@Samuelopez-ansys
Copy link
Copy Markdown
Member

Description

This class is an advanced usage of Stackup 3D class. It should not be part of PyAEDT, and if for some reason, any user needs it, we can think about creating an example.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions Bot added the maintenance Package and maintenance related label Mar 14, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.96%. Comparing base (958b311) to head (3e59aed).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5916      +/-   ##
==========================================
- Coverage   84.98%   84.96%   -0.02%     
==========================================
  Files         162      162              
  Lines       62343    62305      -38     
==========================================
- Hits        52980    52940      -40     
- Misses       9363     9365       +2     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys Samuelopez-ansys changed the title REFACTOR: Deltee ML patch class REFACTOR: Delete ML patch class Mar 14, 2025
Copy link
Copy Markdown
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with creating an example instead of hosting this lines of code.
On top of joblib you should also remove the following files:

  • patch_svr_model_100MHz_1GHz.joblib
  • patch_svr_model_1GHz_10GHz.joblib

Comment thread pyproject.toml
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) March 14, 2025 14:42
Copy link
Copy Markdown
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit 463b124 into main Mar 14, 2025
46 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the refactor/remove_patch_ML branch March 14, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants