REFACTOR: Delete ML patch class#5916
Merged
Samuelopez-ansys merged 6 commits intomainfrom Mar 14, 2025
Merged
Conversation
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5916 +/- ##
==========================================
- Coverage 84.98% 84.96% -0.02%
==========================================
Files 162 162
Lines 62343 62305 -38
==========================================
- Hits 52980 52940 -40
- Misses 9363 9365 +2 🚀 New features to boost your workflow:
|
SMoraisAnsys
requested changes
Mar 14, 2025
Collaborator
SMoraisAnsys
left a comment
There was a problem hiding this comment.
I agree with creating an example instead of hosting this lines of code.
On top of joblib you should also remove the following files:
- patch_svr_model_100MHz_1GHz.joblib
- patch_svr_model_1GHz_10GHz.joblib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This class is an advanced usage of Stackup 3D class. It should not be part of PyAEDT, and if for some reason, any user needs it, we can think about creating an example.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist