Skip to content

FIX: "Time" removed from intrinsincs keys in Steady State simulations#5928

Merged
lorenzovecchietti merged 8 commits intomainfrom
fix/issue_5911
Mar 24, 2025
Merged

FIX: "Time" removed from intrinsincs keys in Steady State simulations#5928
lorenzovecchietti merged 8 commits intomainfrom
fix/issue_5911

Conversation

@lorenzovecchietti
Copy link
Copy Markdown
Contributor

Close #5911

@ansys-reviewer-bot
Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions Bot added the bug Something isn't working label Mar 19, 2025
@lorenzovecchietti lorenzovecchietti changed the title FIX: "Time" should not be among intrinsincs keys in Steady State simulations. FIX: "Time" removed from intrinsincs keys in Steady State simulations. Mar 19, 2025
@lorenzovecchietti lorenzovecchietti changed the title FIX: "Time" removed from intrinsincs keys in Steady State simulations. FIX: "Time" removed from intrinsincs keys in Steady State simulations Mar 19, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.99%. Comparing base (eb5b6fc) to head (0300fdc).
Report is 6 commits behind head on main.

❌ Your patch status has failed because the patch coverage (80.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5928      +/-   ##
==========================================
- Coverage   85.01%   84.99%   -0.03%     
==========================================
  Files         162      162              
  Lines       62358    62361       +3     
==========================================
- Hits        53014    53002      -12     
- Misses       9344     9359      +15     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys
Copy link
Copy Markdown
Member

@lorenzovecchietti Could you add a test?

@lorenzovecchietti lorenzovecchietti merged commit bc3a16a into main Mar 24, 2025
46 of 47 checks passed
@lorenzovecchietti lorenzovecchietti deleted the fix/issue_5911 branch March 24, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

It throws 'AEDT API Error on write', when I am using the method get_temperature_extremum in Icepak.

4 participants