Skip to content

FIX: Exception error for multiple design#5937

Merged
myoung301 merged 9 commits intomainfrom
FIX_Exception_error_for_multiple_design
Apr 21, 2025
Merged

FIX: Exception error for multiple design#5937
myoung301 merged 9 commits intomainfrom
FIX_Exception_error_for_multiple_design

Conversation

@ramin4667
Copy link
Copy Markdown
Contributor

@ramin4667 ramin4667 commented Mar 20, 2025

Description

This PR raises an exception for multiple design definitions with an already opened design.

Issue linked

NA

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions Bot added the bug Something isn't working label Mar 20, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.13%. Comparing base (979f6c2) to head (6d4155f).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5937   +/-   ##
=======================================
  Coverage   85.13%   85.13%           
=======================================
  Files         167      167           
  Lines       63042    63042           
=======================================
+ Hits        53672    53673    +1     
+ Misses       9370     9369    -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@myoung301
Copy link
Copy Markdown
Contributor

@ramin4667 I think the code looks good. Can you add a unit test that will exercise the exception and the close method?

Comment thread src/ansys/aedt/core/filtersolutions.py
@myoung301 myoung301 merged commit 8355d6c into main Apr 21, 2025
31 checks passed
@myoung301 myoung301 deleted the FIX_Exception_error_for_multiple_design branch April 21, 2025 18:47
nunesanderson pushed a commit that referenced this pull request Apr 30, 2025
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants