REFACTOR: 12_post_processing refactoring by nunesanderson · Pull Request #6051 · ansys/pyaedt

nunesanderson · 2025-04-15T14:10:11Z

Description

Post processing test refactor

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

I have tested my changes locally.
I have added necessary documentation or updated existing documentation.
I have followed the coding style guidelines of this project.
I have added appropriate tests (unit, integration, system).
I have reviewed my changes before submitting this pull request.
I have linked the issue or issues that are solved by the PR if any.
I have agreed with the Contributor License Agreement (CLA).

ansys-reviewer-bot · 2025-04-15T14:10:16Z

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

codecov · 2025-04-16T07:53:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.49%. Comparing base (d48283a) to head (a4b176f).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6051      +/-   ##
==========================================
- Coverage   85.15%   82.49%   -2.67%     
==========================================
  Files         167      167              
  Lines       63153    63157       +4     
==========================================
- Hits        53781    52101    -1680     
- Misses       9372    11056    +1684

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gmalinve

@nunesanderson thanks for taking care of this! :)
Here some suggestions:

I'd improve the test method names (test_manipulate_report_A, B, C etc.)
All tests don't have a single purpose, they assert multiple methods.
There are some methods that are asserted more than once in different tests (just as an example you can look at export_config and create_report_from_configuration just to mention a couple). We could check if there are repetitions without decreasing codecov.
There are also some tests (test_parse_vector) where we test protected methods (is it really needed?). We can check.
There are some tests, just as an example test_markers that creates multiple field plots to test markers. Maybe we could avoid some cases and open an aedtz where the field plot is already created.

gmalinve · 2025-04-18T09:32:18Z

+    # @pytest.fixture(autouse=True)
+    # def init(self, local_scratch):
+    #     self.local_scratch = local_scratch


@nunesanderson remove.

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com> Co-authored-by: Samuelopez-ansys <samuel.lopez@ansys.com>

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

…6041) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

…0,<6.2 (#6042) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com> Co-authored-by: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com>

) Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Samuelopez-ansys <samuel.lopez@ansys.com>

Co-authored-by: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com>

Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

…6082) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>

…6088) Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

12_post_processing refactoring

0619129

nunesanderson requested a review from gmalinve April 15, 2025 14:10

gmalinve linked an issue Apr 16, 2025 that may be closed by this pull request

12_post_processing file refactoring #6029

Closed

gmalinve assigned nunesanderson Apr 16, 2025

gmalinve changed the title ~~12_post_processing refactoring~~ REFACTOR: 12_post_processing refactoring Apr 16, 2025

nunesanderson marked this pull request as ready for review April 16, 2025 12:34

gmalinve requested changes Apr 18, 2025

View reviewed changes

nunesanderson added 4 commits April 22, 2025 17:46

functions refactoring - started

d70ed27

functions refactoring - in progress

e5689f8

functions refactoring - in progress

43aef12

functions refactoring - finished

e0108db

nunesanderson force-pushed the refactor/12_post_processing_fixed_pr branch from 0a3bcbc to 997f966 Compare April 28, 2025 10:06

jvela018 and others added 16 commits April 30, 2025 10:26

REFACTOR: Pathlib hfss.py (#6054)

1e809a3

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

DOCS: Update CONTRIBUTORS.md with the latest contributors (#6046)

0dc5e12

Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>

CHORE: Update pre-commit hooks and intend to fix auto update (#6058)

a97222c

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>

FEAT: populate named expressions and improve doc (#6027)

fbea48f

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com> Co-authored-by: Samuelopez-ansys <samuel.lopez@ansys.com>

BUILD(actions): bump ansys/actions from 8 to 9 (#6039)

a41e7b1

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

REFACTOR: Pathlib hfss3dlayout.py (#6057)

f4639ef

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com>

FIX: Adding missed properties (#6045)

23fef49

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

FIX: Exception error for multiple design (#5937)

afdd663

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

CHORE: update CHANGELOG for v0.15.6 (#6065)

4f0a70b

FIX: fix extension manager + add missing icon fields distribution (#6066

55117cd

) Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Samuelopez-ansys <samuel.lopez@ansys.com>

FIX: Return value of download_icepak_3d_component (#6071)

b56143b

Co-authored-by: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com>

maxcapodi78 and others added 16 commits April 30, 2025 10:26

REFACTOR: Refactor virtual compliance class (#6073)

59ad432

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com>

FIX: Return value of download_multiparts (#6075)

2ecd3d3

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com>

FEAT: improved pdf image management (#6076)

70551b7

FEAT: Add assignment argument to plane wave (#6077)

5dfc7d4

Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

chore: adding changelog file 6051.miscellaneous.md [dependabot-skip]

c60e30f

Fixed pdf report issue

2f4de6a

Fixed method name

7aa3a60

Fixed tmatrix

477625a

Fixed Maxwell export_results

6b173ea

FIX: Speedup extension cutout (#6079)

2622e65

FIX: Only force download file if specified (#6083)

294a04d

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

FIX: Fix locale error that happens after matplotlib plot is created (#…

bb99424

…6088) Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

FIX: Remove dummy project fixture (#6091)

90de0ad

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

nunesanderson force-pushed the refactor/12_post_processing_fixed_pr branch from 997f966 to 1033908 Compare April 30, 2025 08:27

github-actions Bot added maintenance Package and maintenance related documentation Improvements or additions to documentation labels Apr 30, 2025

Merge branch 'main' into refactor/12_post_processing_fixed_pr

a4b176f

nunesanderson closed this Apr 30, 2025

nunesanderson deleted the refactor/12_post_processing_fixed_pr branch April 30, 2025 08:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

REFACTOR: 12_post_processing refactoring#6051

REFACTOR: 12_post_processing refactoring#6051
nunesanderson wants to merge 38 commits intomainfrom
refactor/12_post_processing_fixed_pr

nunesanderson commented Apr 15, 2025 •

edited by gmalinve

Loading

Uh oh!

ansys-reviewer-bot Bot commented Apr 15, 2025

Uh oh!

codecov Bot commented Apr 16, 2025 •

edited

Loading

Uh oh!

gmalinve left a comment

Uh oh!

gmalinve Apr 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

nunesanderson commented Apr 15, 2025 • edited by gmalinve Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue linked

Checklist

Uh oh!

ansys-reviewer-bot Bot commented Apr 15, 2025

Uh oh!

codecov Bot commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gmalinve left a comment

Choose a reason for hiding this comment

Uh oh!

gmalinve Apr 18, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

nunesanderson commented Apr 15, 2025 •

edited by gmalinve

Loading

codecov Bot commented Apr 16, 2025 •

edited

Loading