Skip to content

FEAT: Enable gRPC usage and update import paths in EDB module#7567

Open
Samuelopez-ansys wants to merge 14 commits intomainfrom
fix/pyedb_grpc_default_tests
Open

FEAT: Enable gRPC usage and update import paths in EDB module#7567
Samuelopez-ansys wants to merge 14 commits intomainfrom
fix/pyedb_grpc_default_tests

Conversation

@Samuelopez-ansys
Copy link
Copy Markdown
Member

Description

This pull request updates the way certain classes are imported from the pyedb package and modifies a test configuration default. The main focus is on standardizing imports to use the new generic.design_types module and enabling gRPC usage in tests by default.

Import updates for consistency:

  • Changed the import paths for Edb and Siwave classes in src/ansys/aedt/core/edb.py to use pyedb.generic.design_types instead of their previous locations, which helps centralize and standardize type definitions.

Test configuration change:

  • Updated the default value of use_pyedb_grpc to True in tests/conftest.py, enabling gRPC-based communication in tests by default.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@Samuelopez-ansys Samuelopez-ansys requested a review from a team as a code owner April 21, 2026 09:32
@github-actions github-actions Bot added testing Anything related to testing bug Something isn't working labels Apr 21, 2026
eblanco-ansys
eblanco-ansys previously approved these changes Apr 21, 2026
@github-actions github-actions Bot added the maintenance Package and maintenance related label Apr 23, 2026
Copy link
Copy Markdown
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working extensions maintenance Package and maintenance related testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants