Skip to content

fix: docker launch method requires proper network resolution #2493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobPasMue merged 3 commits into from
Jan 7, 2026
Merged

fix: docker launch method requires proper network resolution #2493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc50c27
fix: docker launch method requires proper network resolution
RobPasMue Jan 7, 2026
4a730ce
fix: pre-commit issues on Windows
RobPasMue Jan 7, 2026
d6f18f5
chore: adding changelog file 2493.fixed.md [dependabot-skip]
pyansys-ci-bot Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci_cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,11 @@ jobs:
docker-image: ["core-windows-latest", "core-windows-latest-unstable"]
include:
# Add tracker-label based on use-tracker
# Add experimental flag based on docker-image
- use-tracker: "no"
tracker-label: "Without tracker"
- use-tracker: "yes"
tracker-label: "With tracker"
# Add experimental flag based on docker-image
- docker-image: "core-windows-latest"
experimental: false
- docker-image: "core-windows-latest-unstable"
Expand Down Expand Up @@ -391,11 +391,11 @@ jobs:
docker-image: ["core-linux-latest", "core-linux-latest-unstable"]
include:
# Add tracker-label based on use-tracker
# Add experimental flag based on docker-image
- use-tracker: "no"
tracker-label: "Without tracker"
- use-tracker: "yes"
tracker-label: "With tracker"
# Add experimental flag based on docker-image
- docker-image: "core-linux-latest"
experimental: false
- docker-image: "core-linux-latest-unstable"
Expand Down
1 change: 1 addition & 0 deletions doc/changelog.d/2493.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Docker launch method requires proper network resolution
8 changes: 8 additions & 0 deletions src/ansys/geometry/core/connection/docker_instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,7 @@ def _deploy_container(
image=f"{pygeom_defaults.GEOMETRY_SERVICE_DOCKER_IMAGE}:{image.value[2]}",
detach=True,
auto_remove=True,
network_mode="bridge" if docker_os == "linux" else "nat",
name=name,
ports={"50051/tcp": port},
volumes=volumes,
Expand All @@ -386,6 +387,9 @@ def _deploy_container(
"ANSYS_GRPC_CERTIFICATES": "/certs"
if image.value[1] == "linux"
else "C:/certs",
"SERVER_ENDPOINT": "50051@0.0.0.0"
if image.value[2].startswith("windows")
else "", # This is mostly needed for DMS based images only
},
command=f"--transport-mode={transport_mode}",
)
Expand All @@ -397,6 +401,10 @@ def _deploy_container(
raise RuntimeError(
f"Geometry service Docker image error when initialized. Error: {err.explanation}"
)
except Exception as ex: # pragma: no cover
raise RuntimeError(
f"Geometry service Docker image could not be launched. Error: {str(ex)}"
)

# If the deployment went fine, this means that you have deployed the service.
self._container = container
Expand Down
Loading