-
Notifications
You must be signed in to change notification settings - Fork 2
Added Q3D-Lumerical workflow example following the same guidelines as per previous Maxwell 2D-Lumerical #79. It makes #103 obsolete #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tizianrot
wants to merge
16
commits into
main
Choose a base branch
from
q3d-lumerical-new
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 7 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
5fd7893
Added Q3D-Lumerical workflow example following the same guidelines as…
tizianrot ab1006f
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] 582b551
refactor: cleanup and rephrase some readme files
SMoraisAnsys 04904d5
Merge branch 'main' into q3d-lumerical-new
SMoraisAnsys 08459e3
wip: add missing worklow
SMoraisAnsys 7d11e28
Update q3d-lumerical/requirements_25.1.txt
SMoraisAnsys 4c8c091
Update q3d-lumerical/requirements_25.2.txt
SMoraisAnsys fbf4a58
Apply suggestion from @SMoraisAnsys
SMoraisAnsys 375558f
Merge branch 'main' into q3d-lumerical-new
SMoraisAnsys c5fa282
Update .github/workflows/q3d-lumerical.yml
SMoraisAnsys d26eb4b
ci: revert doc changes after check
SMoraisAnsys e339cd4
chore: cleanup
SMoraisAnsys 1ff4e85
Added brief content after both Maxwell 2D and Q3D example for better …
tizianrot 853b851
Apply suggestions from code review
SMoraisAnsys f546286
Update maxwell2d-lumerical/wf_ml_01_ion_trap_modelling.py
SMoraisAnsys 596389a
Update q3d-lumerical/wf_q3l_01_ion_trap_modelling.py
SMoraisAnsys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| name: Q3D Lumerical Workflow | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| doc-build: | ||
| required: false | ||
| default: false | ||
| type: boolean | ||
| description: 'Whether to build the documentation' | ||
| workflow_call: | ||
| inputs: | ||
| doc-build: | ||
| required: false | ||
| default: false | ||
| type: boolean | ||
| description: 'Whether to build the documentation' | ||
| push: | ||
| branches: | ||
| - main | ||
| pull_request: | ||
| paths: | ||
| - 'q3d-lumerical/**' | ||
|
|
||
| env: | ||
| ANSYSLMD_LICENSE_FILE: ${{ format('1055@{0}', secrets.LICENSE_SERVER )}} | ||
| ANSYS_RELEASE_FOR_DOCS: 25.2 | ||
| ANSYSEM_ROOT252: 'C:\Program Files\ANSYS Inc\v252\AnsysEM' | ||
| MAIN_PYTHON_VERSION: '3.12' | ||
| ON_CI: true | ||
|
|
||
| jobs: | ||
|
|
||
| is-only-docs-required: | ||
| uses: ./.github/workflows/check-docs-required.yml | ||
| with: | ||
| doc-build: ${{ inputs.doc-build || false }} | ||
|
|
||
| q3d-lumerical: | ||
| name: Q3D Lumerical | ||
| runs-on: [self-hosted, Windows, pyansys-workflows] | ||
| needs: is-only-docs-required | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| ansys-release: ${{ needs.is-only-docs-required.outputs.only-docs == 'true' && fromJSON('[25.2]') || fromJSON('[25.2]') }} | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@ff7abcd0c3c05ccf6adc123a8cd1fd4fb30fb493 # v4.2.2 | ||
| with: | ||
| sparse-checkout: | | ||
| q3d-lumerical | ||
| doc | ||
|
|
||
| - name: Set up Python ${{ env.MAIN_PYTHON_VERSION }} | ||
| uses: actions/setup-python@2e3e4b15a884dc73a63f962bff250a855150a234 # v5.6.0 | ||
| with: | ||
| python-version: ${{ env.MAIN_PYTHON_VERSION }} | ||
|
|
||
| - name: Install dependencies | ||
| shell: bash | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| python -m venv .venv | ||
| source .venv/Scripts/activate | ||
| pip install -r q3d-lumerical/requirements_${{ matrix.ansys-release }}.txt | ||
|
|
||
| - name: Run the workflow script | ||
| env: | ||
| AEDT_VERSION: ${{ matrix.ansys-release }} | ||
| shell: bash | ||
| run: | | ||
| source .venv/Scripts/activate | ||
| python q3d-lumerical/wf_q3l_01_ion_trap_modelling.py | ||
|
|
||
| - name: (DOCS) Build the documentation (only on ${{ env.ANSYS_RELEASE_FOR_DOCS}}) | ||
| if: needs.is-only-docs-required.outputs.only-docs == 'true' && matrix.ansys-release == env.ANSYS_RELEASE_FOR_DOCS | ||
| env: | ||
| BUILD_DOCS_SCRIPT: 'q3d-lumerical/wf_q3l_01_ion_trap_modelling.py' | ||
| shell: bash | ||
| run: | | ||
| source .venv/Scripts/activate | ||
| cd doc | ||
| pip install -r requirements.txt | ||
| ./make.bat html | ||
|
|
||
| - name: (DOCS) Adapt the documentation paths | ||
| if: needs.is-only-docs-required.outputs.only-docs == 'true' && matrix.ansys-release == env.ANSYS_RELEASE_FOR_DOCS | ||
| shell: bash | ||
| run: | | ||
| find doc/_build -type f -exec sed -i 's|C:\\Users\\ansys\\actions-runner\\_work\\pyansys-workflows\\pyansys-workflows\\doc\\source\\examples\\q3d-lumerical\\images\\|./images/|g' {} + | ||
|
|
||
| - name: (DOCS) Upload docs artifacts | ||
| if: needs.is-only-docs-required.outputs.only-docs == 'true' && matrix.ansys-release == env.ANSYS_RELEASE_FOR_DOCS | ||
|
SMoraisAnsys marked this conversation as resolved.
|
||
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| name: q3d-lumerical-docs | ||
| path: | | ||
| doc/_build/ | ||
| doc/source/examples/q3d-lumerical/ | ||
| overwrite: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| outputs |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.